Maniphest T219736

ttmserver/ElasticSearchTTMServer.php: Call to a member function getAggregations() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Urbanecm
	Mar 31 2019, 5:37 PM

Description

This query is not working, while a slightly different query with same settings is

[XKD4EwpAAD0AAHUEhW8AAABY] /w/index.php?title=Special:SearchTranslations&match=all&query=stop+wathing+this&language=cs&filter=translated   Error from line 757 of /srv/mediawiki/php-1.33.0-wmf.23/extensions/Translate/ttmserver/ElasticSearchTTMServer.php: Call to a member function getAggregations() on null
#0 /srv/mediawiki/php-1.33.0-wmf.23/extensions/Translate/specials/SpecialSearchTranslations.php(132): ElasticSearchTTMServer->getFacets(NULL)
#1 /srv/mediawiki/php-1.33.0-wmf.23/includes/specialpage/SpecialPage.php(569): SpecialSearchTranslations->execute(NULL)
#2 /srv/mediawiki/php-1.33.0-wmf.23/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
#3 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#4 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(867): MediaWiki->performRequest()
#5 /srv/mediawiki/php-1.33.0-wmf.23/includes/MediaWiki.php(517): MediaWiki->main()
#6 /srv/mediawiki/php-1.33.0-wmf.23/index.php(42): MediaWiki->run()
#7 /srv/mediawiki/w/index.php(3): require(string)
#8 {main}

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Translate	master	+6 -0	Fix exception thrown when no hits are found during translation search

Customize query in gerrit

Related Objects

Mentioned In: Blog Post: Production Excellence #9: March 2019

Event Timeline

Urbanecm created this task.Mar 31 2019, 5:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2019, 5:37 PM

Bawolff updated the task description. (Show Details)Mar 31 2019, 6:10 PM

JJMC89 added a project: Wikimedia-production-error.Mar 31 2019, 7:09 PM

Patriccck added a subscriber: Patriccck.Apr 1 2019, 7:31 PM

Krinkle moved this task from Untriaged to Mar 2019 / 1.33wmf20-23 on the Wikimedia-production-error board.Apr 5 2019, 11:08 PM

12 reports from wmf.23 in Logstash. 1 report from wmf.22 in Logstash.

ElasticSearchTTMServer::getFacets needs a resultset to call getAggregations.

The result set in SpecialSearchTranslations::execute should be set when no exception is thrown.

It is set from CrossLanguageTranslationSearchQuery::getResultSet or SearchableTTMServer::search, both calling many other functions, that makes it hard to follow the whole code path. I have no idea what the search is returning, when nothing is found. It is okay to use showEmptySearch in case of null result set?

Krinkle mentioned this in Blog Post: Production Excellence #9: March 2019.Apr 21 2019, 6:51 PM

Reedy renamed this task from /ttmserver/ElasticSearchTTMServer.php: Call to a member function getAggregations() on null to ttmserver/ElasticSearchTTMServer.php: Call to a member function getAggregations() on null.Apr 23 2019, 9:55 PM

abi_ added a subscriber: abi_.Apr 24 2019, 4:05 AM

abi_ added a project: User-abi_.Apr 28 2019, 11:23 AM

abi_ moved this task from Backlog to In Progress on the User-abi_ board.Apr 29 2019, 5:46 AM

Change 507033 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix exception thrown when no hits are found during translation search

https://gerrit.wikimedia.org/r/507033

gerritbot added a project: Patch-For-Review.Apr 29 2019, 3:12 PM

abi_ claimed this task.Apr 29 2019, 3:12 PM

I had the Translate extension with ElasticSearch as the TTM backend setup on my machine. I was able to reproduce the issue and have submitted a patch that fixes the problem. The resultset was being set only if there are records returned matching the search, causing it to remain null when there were no hits.

abi_ moved this task from In Progress to Under Review on the User-abi_ board.Apr 29 2019, 3:20 PM

Change 507033 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix exception thrown when no hits are found during translation search

https://gerrit.wikimedia.org/r/507033

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 30 2019, 8:00 AM

Nikerabbit moved this task from Backlog to TTMServer on the MediaWiki-extensions-Translate board.Apr 30 2019, 8:24 AM

Nikerabbit moved this task from Under Review to QA on the User-abi_ board.

Nikerabbit removed a project: Patch-For-Review.

Nikerabbit triaged this task as Medium priority.Apr 30 2019, 8:29 AM

Pginer-WMF added a project: Language-Team (Language-2019-April-June).Apr 30 2019, 3:18 PM

abi_ moved this task from Backlog to Needs QA on the Language-Team (Language-2019-April-June) board.May 1 2019, 8:00 AM

• Petar.petkovic moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2019-April-June) board.May 2 2019, 10:09 PM

Looks like this was included in 1.34.0-wmf.3. Last log entry in logstash is from 2019-04-30T17:40:08 which I believe is before the train ran. Because of that I think we can call this done.

Marking as done.

In T219736#5163573, @Nikerabbit wrote:

Looks like this was included in 1.34.0-wmf.3. Last log entry in logstash is from 2019-04-30T17:40:08 which I believe is before the train ran. Because of that I think we can call this done.

Included in (as of now): master, wmf/1.34.0-wmf.3, wmf/1.34.0-wmf.4

Thanks for fix!

Patriccck awarded a token.May 11 2019, 9:51 PM

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM

ttmserver/ElasticSearchTTMServer.php: Call to a member function getAggregations() on nullClosed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Related Objects

Event Timeline

ttmserver/ElasticSearchTTMServer.php: Call to a member function getAggregations() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions