Maniphest T219738

PHP Warning: Array key should be either a string or an integer
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request URL: https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page
Exception file: /srv/mediawiki/php-master/includes/site/SiteList.php:141
Request ID: XKEX6qwQBHcAAF-NRCcAAABB

message

[XKEX6qwQBHcAAF-NRCcAAABB] /wiki/Main_Page?debug=true   ErrorException from line 141 of /srv/mediawiki/php-master/includes/site/SiteList.php: PHP Warning: Array key should be either a string or an integer

trace

#0 /srv/mediawiki/php-master/includes/site/SiteList.php(141): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-master/includes/site/CachingSiteStore.php(132): SiteList->hasSite(boolean)
#2 /srv/mediawiki/php-master/includes/WikiMap.php(88): CachingSiteStore->getSite(boolean)
#3 /srv/mediawiki/php-master/includes/WikiMap.php(44): WikiMap::getWikiWikiReferenceFromSites(boolean)
#4 /srv/mediawiki/php-master/extensions/EventBus/includes/EventFactory.php(46): WikiMap::getWiki(boolean)
#5 /srv/mediawiki/php-master/extensions/EventBus/includes/EventFactory.php(144): EventFactory::getDomain(string)
#6 /srv/mediawiki/php-master/extensions/EventBus/includes/EventFactory.php(998): EventFactory::createEvent(string, string, array, string)
#7 /srv/mediawiki/php-master/extensions/EventBus/includes/JobQueueEventBus.php(71): EventFactory->createJobEvent(string, JobSpecification)
#8 /srv/mediawiki/php-master/includes/jobqueue/JobQueue.php(340): JobQueueEventBus->doBatchPush(array, integer)
#9 /srv/mediawiki/php-master/includes/jobqueue/JobQueue.php(310): JobQueue->batchPush(array, integer)
#10 /srv/mediawiki/php-master/includes/jobqueue/JobQueueGroup.php(158): JobQueue->push(array)
#11 /srv/mediawiki/php-master/includes/deferred/JobQueueEnqueueUpdate.php(57): JobQueueGroup->push(array)
#12 /srv/mediawiki/php-master/includes/deferred/DeferredUpdates.php(274): JobQueueEnqueueUpdate->doUpdate()
#13 /srv/mediawiki/php-master/includes/deferred/DeferredUpdates.php(219): DeferredUpdates::runUpdate(JobQueueEnqueueUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#14 /srv/mediawiki/php-master/includes/deferred/DeferredUpdates.php(143): DeferredUpdates::execute(array, string, integer)
#15 /srv/mediawiki/php-master/includes/MediaWiki.php(909): DeferredUpdates::doUpdates(string)
#16 /srv/mediawiki/php-master/includes/MediaWiki.php(733): MediaWiki->restInPeace(string, boolean)
#17 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
#18 {main}

Impact

Notes

Software version: 1.33.0-alpha (d159839)
10,000+ hits this week: https://kibana4.wmflabs.org/goto/f2032ade7e8c202c13c1e59438bd9449

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix event domain fetching code.	Ppchelko	mediawiki/extensions/EventBus	master	+24 -23

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dduvall	T206678 1.33.0-wmf.24 deployment blockers
		Resolved	PRODUCTION ERROR	• Pchelolo	T219738 PHP Warning: Array key should be either a string or an integer

Event Timeline

MarcoAurelio created this task.Mar 31 2019, 7:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2019, 7:49 PM

While the example I took was from enwiki beta, by far the wiki with most error messages logged is wikidatawiki beta (XKEb6qwQBGoAAETM02kAAAAS for example) Event-Platform and MediaWiki-Core-JobQueue are mentioned. Not sure if tag them here. I'd appreciate someone more knowledgeable to take a look at the traces and tag as appropriate. Thank you.

I think there might be more than one thing going wrong here, but primarily:

4f72d439

added some code $wikiRef = WikiMap::getWiki( false );

However, this method is not documented as having false as a permissible value. Its supposed to have the wiki id of the target wiki. So this code looks wrong.

Bawolff added a subscriber: • holger.knust.Mar 31 2019, 8:50 PM

"EventFactory.php" line 144 also seems kind of wrong. Its passing the wiki name to self::getDomain, but the docs for self::getDomain indicate that that parameter is a boolean for whether or not the wiki display name is used, not as a value to pass the wikiid

Bawolff added a project: Event-Platform.Mar 31 2019, 8:53 PM

Restricted Application added a project: Analytics. · View Herald TranscriptMar 31 2019, 8:53 PM

4f72d439 is Event-Platform and is causing T219737 as well - ping @Pchelolo too.

Change 500363 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EventBus@master] Fix event domain fetching code.

https://gerrit.wikimedia.org/r/500363

gerritbot added a project: Patch-For-Review.Mar 31 2019, 9:21 PM

Milimetric moved this task from Incoming to Radar on the Analytics board.Apr 1 2019, 3:52 PM

Is this a wmf.24 blocker as T219737 was?

MarcoAurelio added a parent task: T206678: 1.33.0-wmf.24 deployment blockers.Apr 1 2019, 8:39 PM

MarcoAurelio mentioned this in T206678: 1.33.0-wmf.24 deployment blockers.

Marking this UBN as is policy for all deployment blockers.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 2 2019, 5:46 PM

The https://gerrit.wikimedia.org/r/500363 fixes it. Don't want to self-merge my own patch though.

In T219738#5078550, @Pchelolo wrote:

The https://gerrit.wikimedia.org/r/500363 fixes it. Don't want to self-merge my own patch though.

Thanks! Looked pretty straightforward so I went ahead and +2'd it. Assuming it passes gate-and-submit, I'll start cutting the branch. If you could verify on Beta prior to deployment, however, that would be helpful.

Change 500363 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] Fix event domain fetching code.

https://gerrit.wikimedia.org/r/500363

greg edited projects, added: Beta-Cluster-reproducible; removed: Beta-Cluster-Infrastructure.Apr 2 2019, 6:34 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 2 2019, 7:01 PM

If you could verify on Beta prior to deployment, however, that would be helpful.

The error log has disappeared from beta since the patch has been deployed. Verified.

Yay. Thank you!

• mobrovac added projects: Platform Team Workboards (Done with CPT), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)).Apr 3 2019, 3:21 PM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM

Aklapper edited projects, added: Analytics-Radar; removed: Analytics.Jun 10 2020, 6:43 AM

PHP Warning: Array key should be either a string or an integerClosed, ResolvedPublicPRODUCTION ERRORActions