⚓ T219826 Add 'error' icon to 'alerts' icon pack

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.31.3	mediawiki/core	master	+403 -355
	icons: Add 'error' icon to 'alerts' pack	oojs/ui	master	+14 -0

Status	Assigned	Task
Resolved	• Spage	T88392 Update UI library documentation
Resolved	Volker_E	T118925 [GOAL] Style Guide - Guide on how/when to use components
Resolved	Volker_E	T151117 Make an official statement on which guide for WikimediaUI is the official one to remove confusion
Resolved	Volker_E	T110727 Consolidate documentation for recommended color palette
Resolved	Volker_E	T111117 [EPIC] Enhance accessibility of OOUI & MediaWiki UI library / LSG / MediaWiki General to screen readers and color-deficient users
Invalid	Volker_E	T98526 Inactive notification badge colors not compliant with WCAG 2.0 accessibility guidelines
Resolved	Volker_E	T109915 Improve color palette to comply with WCAG 2.0 min level AA and color-deficiency-friendly.
Resolved	Volker_E	T123812 Invalid text input `border`/`box-shadow` and dialog error border color should be set to `@destructive`
Resolved	Volker_E	T127405 Review current style and integrate Messages and message boxes (errors, warnings) as WikimediaUI component
Resolved	Volker_E	T219826 Add 'error' icon to 'alerts' icon pack

Volker_E created this task.Apr 1 2019, 6:42 PM

Restricted Application added a project: UI-Standardization. · View Herald TranscriptApr 1 2019, 6:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ladsgroup awarded a token.Apr 1 2019, 6:43 PM

Change 500532 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Add 'error' icon to 'alerts' pack

https://gerrit.wikimedia.org/r/500532

gerritbot added a project: Patch-For-Review.Apr 1 2019, 7:12 PM

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Apr 1 2019, 8:19 PM

What's happening to 'notice'? We will now have three framed exclamation mark icons (circle, triangle, octagon)

notice is going to be deprecated, both message and icon, see T218236

Change 500532 merged by jenkins-bot:
[oojs/ui@master] icons: Add 'error' icon to 'alerts' pack

https://gerrit.wikimedia.org/r/500532

In T219826#5075887, @Volker_E wrote:

notice is going to be deprecated, both message and icon, see T218236

In T218236 I don't see any discussion about whether to deprecate the icon as well. Since the icon is used in some other places (comment node/inspector/tool in VE and perhaps other), this needs more discussion and a reasonable alternative icon.

Thanks @Schnark, I agree when looking through code. The main reason for thinking deprecating the icon would be wishful was, that 'alerts' pack is one of the packs which would be loaded on every page once T139779 is done and as long as T160690 is not resolved. We need to keep 'alerts' pack small.
But we should consider instead moving 'notice' out, best possibly to 'interactions' pack.