| Esanders | |
| Apr 1 2019, 7:08 PM |
| F28584572: image.png | |
| Apr 5 2019, 1:59 PM |
| F28584568: image.png | |
| Apr 5 2019, 1:57 PM |
| F28550752: image.png | |
| Apr 1 2019, 7:08 PM |
| F28550687: image.png | |
| Apr 1 2019, 7:08 PM |
| F28550745: image.png | |
| Apr 1 2019, 7:08 PM |
There are two selections on the page with the same treatment. It is not clear the upper one is deactivated, and therefore that if I start typing it will overwrite the bottom one:
Google Docs uses a grey selection when the document is blurred, or the cursor is in the link inspector:
 |  |  |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Esanders | T208826 Toolbar and toolbar dialogs (e.g. special characters tray) unexpectedly become disabled after clicking on page title | |||
| Resolved | Esanders | T219813 VE article editor should never have a NullSelection | |||
| Resolved | Esanders | T219829 De-activated selections should be visually distinct |
Focusable nodes make this a bit problematic, as does mobile, where we de-activate the surface during various interactions to hide the keyboard.
Change 500741 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Make null-selection-on-blur optional
Change 500745 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Make deactivated selections grey
https://gerrit.wikimedia.org/r/500741 unassigned from this task
Just https://gerrit.wikimedia.org/r/500745 to review
Change 500745 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Make deactivated selections grey
Change 501385 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2dc41ef9b)
Change 501385 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2dc41ef9b)
Change 502498 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Don't make selection grey on mobile preparePasteTargetForCopy
Change 502498 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Don't make selection grey on mobile preparePasteTargetForCopy
Change 502522 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6cc4cd1f0)
Change 502522 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6cc4cd1f0)
