Page MenuHomePhabricator
Create Task
Maniphest T219832

checkComposerLockUpToDate.php doesn't handle non-exact version constraints properly
Closed, ResolvedPublic
Actions

Description

Recently on irc jubo2 was complaining about http://dpaste.com/1MQST9Z where update.php refused to run, but composer was saying everything is ok.

It looks like checkComposerLockUpToDate.php/update.php just does string equality, so it will explode on the fancier version constraints.

It sounds like the user had modified his composer.json file to get dependencies needed by various extensions (see chat log at https://wm-bot.wmflabs.org/logs/%23mediawiki/20190401.txt ) I'm not sure if that is the reccomended way of doing things, but even if it isn't, update.php should not explode this way.

Related Objects

Event Timeline

Bawolff created this task.Apr 1 2019, 7:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2019, 7:54 PM
Bawolff mentioned this in T243933: MediaWiki 1.34.0 could not be updated with wikimedia/css-sanitizer: 2.0.1.Mar 28 2020, 12:16 PM
Reedy closed this task as Resolved.Mar 28 2020, 1:59 PM
Reedy assigned this task to cscott.
Reedy added subscribers: cscott, Reedy.

@cscott fixed checkComposerLockUpToDate.php in I889584 / 3b0b9aa8ad35b9a567619186ac2174240db58726

And that was backported to the last set of releases as per https://gerrit.wikimedia.org/r/#/q/I8895843a5b1116fca42e0c7179a2907fe84a74d1 so it's in 1.34.1/1.33.3/1.31.7

Seb35 subscribed.Nov 17 2020, 10:19 AM

This was a duplicate of T141225. Things evolve -- and I’m happy with this new behaviour.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits