Description

Mustache 1.0.0 is shipped in mediawiki core. This is seriously out of date and should be bumped to 3.0.1. We'd like to update this.

Looking at:
https://github.com/janl/mustache.js/blob/v3.0.1/MIGRATING.md
https://github.com/janl/mustache.js/blob/v3.0.1/CHANGELOG.md

There seems to be no major changes between Mustache 1.0.0 and 3.0.0 so this should not cause any problems, but consider this bug a heads up that this might happen within the next 2 months.

Acceptance criteria

resources/lib/foreign-resources.yaml has been updated to identify the new version
Mustache 3.0.1 is shipped to users rather than the outdated 1.0

Details

	Subject	Repo	Branch	Lines +/-
	Bump Mustache from 1.0.0 to 3.0.1	mediawiki/core	master	+274 -169

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved	Jdlrobson	T127268 Dismantle ResourceLoader's "targets" system
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	Jdlrobson	T195482 [EPIC] Review and refactor MobileFrontend components used by Minerva
Resolved	Jdlrobson	T166905 [EPIC] Talk about and improve our frontend code architecture
Resolved	pmiazga	T94086 [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates
Resolved	Jdlrobson	T219839 Bump mediawiki core Mustache version from 1.0.0 to 3.0.1

Event Timeline

Jdlrobson created this task.Apr 1 2019, 11:09 PM

Restricted Application added projects: Discovery-Search, Performance-Team. · View Herald TranscriptApr 1 2019, 11:09 PM

Change 500632 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Bump Mustache from 1.0.0 to 3.0.1

https://gerrit.wikimedia.org/r/500632

gerritbot added a project: Patch-For-Review.Apr 1 2019, 11:09 PM

EBernhardson removed projects: Discovery-Search, CirrusSearch.Apr 4 2019, 5:09 PM

(PerformanceInspector only uses mustache templates through RL, it doesn't interact with the Mustache library itself and shouldn't be affected by any of its changes.)

Change 500632 merged by jenkins-bot:
[mediawiki/core@master] Bump Mustache from 1.0.0 to 3.0.1

https://gerrit.wikimedia.org/r/500632

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Apr 10 2019, 5:00 PM

Jdforrester-WMF closed this task as Resolved.Apr 10 2019, 7:02 PM

Jdforrester-WMF assigned this task to Jdlrobson.