Page MenuHomePhabricator

Bump mediawiki core Mustache version from 1.0.0 to 3.0.1
Closed, ResolvedPublic

Description

Mustache 1.0.0 is shipped in mediawiki core. This is seriously out of date and should be bumped to 3.0.1. We'd like to update this.

Looking at:
https://github.com/janl/mustache.js/blob/v3.0.1/MIGRATING.md
https://github.com/janl/mustache.js/blob/v3.0.1/CHANGELOG.md

There seems to be no major changes between Mustache 1.0.0 and 3.0.0 so this should not cause any problems, but consider this bug a heads up that this might happen within the next 2 months.

Acceptance criteria

  • resources/lib/foreign-resources.yaml has been updated to identify the new version
  • Mustache 3.0.1 is shipped to users rather than the outdated 1.0

Event Timeline

Change 500632 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Bump Mustache from 1.0.0 to 3.0.1

https://gerrit.wikimedia.org/r/500632

(PerformanceInspector only uses mustache templates through RL, it doesn't interact with the Mustache library itself and shouldn't be affected by any of its changes.)

Change 500632 merged by jenkins-bot:
[mediawiki/core@master] Bump Mustache from 1.0.0 to 3.0.1

https://gerrit.wikimedia.org/r/500632

Jdforrester-WMF closed this task as Resolved.Apr 10 2019, 7:02 PM
Jdforrester-WMF assigned this task to Jdlrobson.