Page MenuHomePhabricator
Create Task
Maniphest T219872

P<id> and Q<id> links don't display wikidata icon
Closed, ResolvedPublic
Actions

Description

Designs (https://wikimedia.invisionapp.com/share/NJOIMI9D6SX#/screens/324924537) displayed a wikidata logo in front of the P<id> and Q<id> links in the depicts widget.
Those are currently missing.
There's CSS to display them (by using .wbmi-entity-link-foreign-repo-wikidata or .wbmi-entity-link-foreign-repo-wikidata), but JS & PHP don't currently recognize those items as foreign wikidata items.

Acceptance criteria

https://commons.wikimedia.beta.wmflabs.org/wiki/File:Photo_on_08-02-2019_at_16.35.jpg

  • Links to wikidata items (all P<id> and Q<id> things on the right) should have a wikidata icon in front of them

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Follow-up a0143594: Production uses 'd' as the interwiki for Wikidatamediawiki/extensions/WikibaseMediaInfomaster+2 -1
Extract repository name for entitiesmediawiki/extensions/WikibaseMediaInfomaster+54 -28
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Apr 2 2019, 2:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2019, 2:08 PM
matthiasmullie added projects: Structured-Data-Team-Current-Work, SDC-Statements (Depicts-Crawling).Apr 2 2019, 2:09 PM
• Ramsey-WMF triaged this task as Medium priority.Apr 2 2019, 3:54 PM
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
gerritbot added a comment.Apr 5 2019, 11:33 AM

Change 501547 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Extract repository name for entities

https://gerrit.wikimedia.org/r/501547

gerritbot added a project: Patch-For-Review.Apr 5 2019, 11:33 AM
matthiasmullie mentioned this in rEWBI55a4532cc76d: Extract repository name for entities.Apr 5 2019, 11:35 AM
matthiasmullie mentioned this in rEWBI28fb776af8c7: Extract repository name for entities.
matthiasmullie mentioned this in rEWBI8044b0df5789: Extract repository name for entities.Apr 5 2019, 11:40 AM
matthiasmullie mentioned this in rEWBIba1867aa04fb: Extract repository name for entities.
matthiasmullie claimed this task.Apr 5 2019, 11:45 AM
matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.
Jdforrester-WMF mentioned this in rEWBIf813da606b2d: Extract repository name for entities.Apr 5 2019, 3:48 PM
Jdforrester-WMF mentioned this in rEWBI3103f208125c: Extract repository name for entities.Apr 5 2019, 4:17 PM
gerritbot added a comment.Apr 5 2019, 4:34 PM

Change 501547 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Extract repository name for entities

https://gerrit.wikimedia.org/r/501547

matthiasmullie reassigned this task from matthiasmullie to Edtadros.Apr 5 2019, 4:38 PM
matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 5 2019, 5:01 PM
gerritbot added a comment.Apr 5 2019, 5:05 PM

Change 501637 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Follow-up a0143594: Production uses 'd' as the interwiki for Wikidata

https://gerrit.wikimedia.org/r/501637

Jdforrester-WMF mentioned this in rEWBIe5b4ea5ce0d4: Follow-up a0143594: Production uses 'd' as the interwiki for Wikidata.Apr 5 2019, 5:08 PM
gerritbot added a comment.Apr 5 2019, 5:26 PM

Change 501637 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Follow-up a0143594: Production uses 'd' as the interwiki for Wikidata

https://gerrit.wikimedia.org/r/501637

• Ha78na claimed this task.Apr 16 2019, 4:15 PM
• Ha78na added subscribers: Edtadros, • Ha78na.

I've QA'ed this on test commons and it looks good, I see icons.

• Ha78na moved this task from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.Apr 16 2019, 4:15 PM
• Ramsey-WMF closed this task as Resolved.Apr 23 2019, 11:24 PM
• Ramsey-WMF subscribed.

Verified on production.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits