Page MenuHomePhabricator
Create Task
Maniphest T219880

The text "(No difference)" no longer appears when comparing two revisions on a page with no net changes between them on en-wiki
Closed, DuplicatePublic
Actions

Description

Awhile ago (a few weeks ago, perhaps...), I started noticing that the text "(No difference)" is no longer displayed on en-wiki when I compare two revisions on a page where the net changes are zero / none / nothing.

Example: https://en.wikipedia.org/w/index.php?title=Terry_Gilliam&diff=890625820&oldid=889228510
Screenshot with text missing:

diff.jpg (938×1 px, 406 KB)

Screenshot of what it should look like:
diff2.jpg (955×1 px, 228 KB)

I can confirm that testing it while logged out of Wikipedia, and using a different browser, such as (gulp) Internet Explorer all show the same thing, so it's definitely not a script, setting, browser plug-in, or issue in those regards.

I've asked others on IRC, and they confirmed that they also no longer see this text displayed when comparing diffs with no net changes. Is this an issue that others also see here? If so, it would be great to have this resolved. I like seeing this text, as it clearly confirms that I'm looking at two revisions where there are no net changes or differences in the text.

I'm happy to answer any questions or provide any information necessary - just let me know.

Related Objects

Event Timeline

Oshwah created this task.Apr 2 2019, 2:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2019, 2:51 PM
Oshwah renamed this task from The text "[No difference]" no longer appears when comaring two revisions on a page with no net changes between them to The text "(No difference)" no longer appears when comaring two revisions on a page with no net changes between them on en-wiki.Apr 2 2019, 2:54 PM
Oshwah updated the task description. (Show Details)
Oshwah updated the task description. (Show Details)Apr 2 2019, 2:58 PM
Ammarpad added a project: MediaWiki-Page-diffs.Apr 2 2019, 4:19 PM
Ammarpad renamed this task from The text "(No difference)" no longer appears when comaring two revisions on a page with no net changes between them on en-wiki to The text "(No difference)" no longer appears when comparing two revisions on a page with no net changes between them on en-wiki.Apr 2 2019, 4:25 PM
Ammarpad subscribed.Apr 7 2019, 7:35 AM

Hi @Oshwah. I cannot reproduce this. I am seeing the "(No difference)" text correctly. Can you confirm you can still reproduce this?

Oshwah added a comment.Apr 10 2019, 11:46 AM

@Ammarpad - Interesting! Something must've changed over the last week or so, because it's now working as it should be. I wonder what changed....

Oshwah added a comment.EditedApr 10 2019, 9:40 PM

@Ammarpad - it seems to have disappeared again. I noticed it again with the diff linked below, and I see it missing again when clicking on the diff I provided in the case description above.

Diff: https://en.wikipedia.org/w/index.php?title=User_talk:Jackin_Johnny&diff=891900756&oldid=891899293

What do you see?

Ammarpad added a comment.Apr 12 2019, 2:27 PM
In T219880#5102733, @Oshwah wrote:

What do you see?

This

Screen Shot 2019-04-12 at 3.22.57 PM.png (900×1 px, 351 KB)

Ammarpad changed the task status from Open to Stalled.Apr 17 2019, 3:07 PM

Stalled. Though probably this is Invalid as it still works for me like in this diff.

Oshwah added a comment.EditedApr 17 2019, 10:50 PM

@Ammarpad: Interesting! It's as if it appears and disappears, I guess? I see the "(No difference)" text gone on certain revision diffs, then when I check in on this ticket and see that you've responded saying that you don't see a problem... I click on the diff and it's there and visible just fine...

Examples:

https://en.wikipedia.org/w/index.php?title=User_talk%3AJackin_Johnny&type=revision&diff=891900756&oldid=891899293 (the text is not visible for me)

https://en.wikipedia.org/w/index.php?diff=256793 (the text is visible just fine)

https://en.wikipedia.org/w/index.php?title=Herman_Melville&type=revision&diff=874156574&oldid=872543505 (same with another revision on this page)

I wonder if this is an issue affecting some editors and only occurs on revision comparisons that happened after a certain date? It seems like all the recent or newer ones (like 2019 year?) aren't showing the text, while comparing older revisions do...

Aklapper closed this task as Declined.Sep 6 2019, 2:25 PM

As nobody has managed to properly reproduce I'm going to close this task... I see (No difference). When this happens again, please also check the very same diff view with safemode: https://www.mediawiki.org/wiki/Help:Locating_broken_scripts to make sure this is not a side effect of some gadget or script.

Aklapper added a comment.Sep 6 2019, 2:32 PM

Ah. Just found T228761 which has an explanation for this, so I am merging this task into T228761: Empty diff does not show "(No difference)" when it's retrieved from cache.

Aklapper closed this task as a duplicate of T228761: Empty diff does not show "(No difference)" when it's retrieved from cache.Sep 6 2019, 2:32 PM
Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL