|Resolved||Addshore||T208425 [EPIC] Kill the wb_terms table|
|Resolved||ArielGlenn||T226167 audit public tables and make sure we dump them all|
|Resolved||Addshore||T219175 [Mega] - Migrate data from wb_terms to new schema|
|Resolved||Addshore||T219121 [Checkpoint 2] Refactor Write & Migration code for Properties|
|Resolved||None||T219894 Create maintenance script for migrating property terms to new schema|
|Resolved||Ladsgroup||T219296 Update TermSqlStore to comply with EntityTermStoreWriter interface|
Don't think it is a good idea to modify the existing RebuildTermSqlIndex code. We can just create a new script. The existing code has things in there we don't need, and still having the wb_terms specific thing around might be useful to various users.
AFAIK the script we currently have (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/505670) is sufficient for this task. It has continuation based on page id rather than property id. I figure that won't fly for items but likely is OK for properties. Do we need continuation at all for properties?
There is some issues though. Some properties result in an error, and on re-run many of them do.
When I throw the exception I get this: https://pastebin.com/ejFn1pnT
*Somehow* a duplicate entry is getting inserted. I added an extra test for this but the test is not catching the issue. https://github.com/wmde/doctrine-term-store/pull/7 Probably this is some kind of evil encoding issue.
I'm calling it a day. Current guess is that the tables are not created right because we are not using this setting in mediawiki/doctrine-connection.
Or maybe something is wrong here https://github.com/wmde/doctrine-term-store/blob/master/src/PackagePrivate/Doctrine/NormalizedStore.php#L100-L105