Page MenuHomePhabricator

Metadata/Add data step right alignment issues
Closed, ResolvedPublic

Description

User story: n/a

We have this:
The right-alignment for the Metadata (soon to be "Add data" per T219945 ) step looks off. Optically, the Publish buttons look unaligned, even though they actually are, because of the varying positions of the Wizard steps, the thumbnail, and the Depicts panel.

We want this:
Let's explore ways of making the right-alignment of all of the Upload Wizard elements align better (open to discussion on what would be best, technically speaking).

Acceptance Criteria:

  • Fix right alignment of elements on the Metadata/Add data step

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2019, 11:07 PM
PDrouin-WMF updated the task description. (Show Details)Apr 2 2019, 11:28 PM
Ramsey-WMF triaged this task as Normal priority.Apr 2 2019, 11:34 PM

Extending the length of the top gray bar a bit may help as an "easy" fix. Nudging the image and the depicts panel to the right just a bit should finish it off. But we'll leave it up to Matthias :)

Change 500902 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Less agressive rounding of arrow steps width

https://gerrit.wikimedia.org/r/500902

Top grey bar (steps) had an incorrect length because it rounded the individual steps too aggressively (100% divided by 6 is no longer an integer)
The depicts panel has padding on the right because that's default for those OOUI panels, but that's easy to override.
Both have patches in.

Change 500903 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Improve styling of depicts widget

https://gerrit.wikimedia.org/r/500903

Change 500902 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Less agressive rounding of arrow steps width

https://gerrit.wikimedia.org/r/500902

Change 500903 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Improve styling of depicts widget

https://gerrit.wikimedia.org/r/500903

Ramsey-WMF closed this task as Resolved.May 7 2019, 10:57 PM

Fixed on production.