Maniphest T219947

Metadata/Add data step right alignment issues
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• PDrouin-WMF
	Apr 2 2019, 11:07 PM

Description

User story: n/a

We have this:
The right-alignment for the Metadata (soon to be "Add data" per T219945 ) step looks off. Optically, the Publish buttons look unaligned, even though they actually are, because of the varying positions of the Wizard steps, the thumbnail, and the Depicts panel.

We want this:
Let's explore ways of making the right-alignment of all of the Upload Wizard elements align better (open to discussion on what would be best, technically speaking).

Acceptance Criteria:

Fix right alignment of elements on the Metadata/Add data step

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Improve styling of depicts widget	mediawiki/extensions/UploadWizard	master	+10 -0
	Less agressive rounding of arrow steps width	mediawiki/extensions/UploadWizard	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Resolved		• Ramsey-WMF	T199352 Deploy Structured Data on Commons with arbitrary Statements
Resolved		• Ramsey-WMF	T215304 "Depicts walking": Add/edit depicts statements in UploadWizard
Resolved		Edtadros	T219947 Metadata/Add data step right alignment issues

Event Timeline

• PDrouin-WMF created this task.Apr 2 2019, 11:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2019, 11:07 PM

• PDrouin-WMF added a parent task: T215304: "Depicts walking": Add/edit depicts statements in UploadWizard.Apr 2 2019, 11:07 PM

• PDrouin-WMF updated the task description. (Show Details)Apr 2 2019, 11:28 PM

• Ramsey-WMF assigned this task to matthiasmullie.Apr 2 2019, 11:30 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Team-Current-Work, SDC-Statements (Depicts-Walking).

• Ramsey-WMF triaged this task as Medium priority.Apr 2 2019, 11:34 PM

Extending the length of the top gray bar a bit may help as an "easy" fix. Nudging the image and the depicts panel to the right just a bit should finish it off. But we'll leave it up to Matthias :)

Change 500902 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Less agressive rounding of arrow steps width

https://gerrit.wikimedia.org/r/500902

gerritbot added a project: Patch-For-Review.Apr 3 2019, 8:51 AM

Top grey bar (steps) had an incorrect length because it rounded the individual steps too aggressively (100% divided by 6 is no longer an integer)
The depicts panel has padding on the right because that's default for those OOUI panels, but that's easy to override.
Both have patches in.

Change 500903 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Improve styling of depicts widget

https://gerrit.wikimedia.org/r/500903

matthiasmullie reassigned this task from matthiasmullie to Edtadros.Apr 3 2019, 3:51 PM

matthiasmullie moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.

matthiasmullie subscribed.

Change 500902 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Less agressive rounding of arrow steps width

https://gerrit.wikimedia.org/r/500902

Change 500903 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Improve styling of depicts widget

https://gerrit.wikimedia.org/r/500903

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 3 2019, 5:01 PM

Jdforrester-WMF removed a project: Patch-For-Review.May 1 2019, 5:51 PM