Maniphest T219956

Remove `.background-size()` LESS mixin, deprecated in MW 1.27
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Apr 3 2019, 2:10 AM

Description

Removing .background-size() LESS mixin, deprecated in MW 1.27 as part of T121473: background-size mixin should not generate vendor prefixes
Android 2 is pretty much dead, 0.1% as of 2019-03-24.
Firefox 3.6 is also affected, is also at 0.1% as of 2019-03-24.

Moreover the mixin is

not used consistently at all, putting the support at esoteric treatment levels
not necessary to show basic content or even interact with the site

Proposed outcome

[[ https://codesearch.wmflabs.org/search/?q=(%3F%3A%5C.background%5C-size)&i=nope&files=&repos= | Remove all instances of .background-size() ]]
- MediaWiki
- QuickSurveys
- RelatedArticles
- MobileFrontend
- MinervaNeue
Remove mixin and add note to release notes, target MW 1.33

Details

Subject	Repo	Branch	Lines +/-
Remove `.background-size()` mixin usage	mediawiki/extensions/MobileFrontend	REL1_33	+3 -6
Remove `.background-size()` mixin usage	mediawiki/extensions/RelatedArticles	REL1_33	+0 -1
Remove `.background-size()` mixin usage	mediawiki/extensions/RelatedArticles	master	+0 -1
Remove `.background-size()` mixin usage	mediawiki/extensions/MobileFrontend	master	+3 -6
Remove `background-size()` LESS mixin.	mediawiki/core	master	+1 -7
Remove `.background-size()` mixin usage	mediawiki/skins/MinervaNeue	master	+4 -7
Remove `.background-size()` mixin usage	mediawiki/extensions/QuickSurveys	master	+2 -2
Remove `.background-size()` mixin usage	mediawiki/core	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: rEQS19814024e096: Remove `.background-size()` mixin usage
Mentioned Here: T121473: background-size mixin should not generate vendor prefixes

Event Timeline

Volker_E created this task.Apr 3 2019, 2:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2019, 2:10 AM

Change 500881 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500881

gerritbot added a project: Patch-For-Review.Apr 3 2019, 2:21 AM

Volker_E updated the task description. (Show Details)Apr 3 2019, 2:32 AM

Change 500883 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500883

Change 500885 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500885

Change 500886 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/QuickSurveys@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500886

Change 500887 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/RelatedArticles@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500887

Diffusion mentioned this in rEQS19814024e096: Remove `.background-size()` mixin usage.Apr 3 2019, 3:06 AM

Change 500885 merged by jenkins-bot:
[mediawiki/core@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500885

Change 500886 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500886

Change 500887 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500887

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 3 2019, 7:01 PM

Change 500883 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500883

Jdforrester-WMF updated the task description. (Show Details)Apr 3 2019, 11:58 PM

Change 500881 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/500881

Volker_E updated the task description. (Show Details)Apr 4 2019, 2:16 AM

Change 501129 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Remove background-size() LESS mixin.

https://gerrit.wikimedia.org/r/501129

Change 501129 merged by jenkins-bot:
[mediawiki/core@master] Remove background-size() LESS mixin.

https://gerrit.wikimedia.org/r/501129

Jdforrester-WMF closed this task as Resolved.Apr 4 2019, 6:41 PM

Jdforrester-WMF assigned this task to Volker_E.

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF updated the task description. (Show Details)

Change 519660 had a related patch set uploaded (by Paladox; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@REL1_33] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/519660

gerritbot added a project: Patch-For-Review.Jun 28 2019, 3:56 PM

Change 520318 had a related patch set uploaded (by Paladox; owner: VolkerE):
[mediawiki/extensions/RelatedArticles@REL1_33] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/520318

Change 519660 merged by Niedzielski:
[mediawiki/extensions/MobileFrontend@REL1_33] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/519660

Change 520318 merged by Niedzielski:
[mediawiki/extensions/RelatedArticles@REL1_33] Remove .background-size() mixin usage

https://gerrit.wikimedia.org/r/520318

Maintenance_bot removed a project: Patch-For-Review.Jul 3 2019, 3:11 PM

Volker_E moved this task from Inbox to Done on the Front-end-Standards-Group board.Dec 11 2019, 12:46 AM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 11 2019, 12:46 AM

Remove `.background-size()` LESS mixin, deprecated in MW 1.27Closed, ResolvedPublicActions