Page MenuHomePhabricator

mobile-html existing saved article migration
Closed, DuplicatePublic

Description

Ensure that users with articles saved with older non-mobile-html versions of the app can still view their articles offline with the new version of the app.

Initial implemenation idea (subject to change):

Migrate existing saved articles to a format compatible with the new mobile-html based article view. All existing saved articles are migrated in the background in a manner that doesn't significantly affect normal use of the app. If a user tries to view an unmigrated article while offline, that article is migrated immediately and is viewable offline.

Event Timeline

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptApr 3 2019, 2:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think it's probably easiest to just redownload the saved pages.

@bearND it's definitely easiest to redownload the saved pages, but the intent is to be able to upgrade the app without losing any of the pages that were saved for offline. So if a user downloads saved pages, upgrades the app, then reopens the app offline, their saved pages should still be there. Whether that means keeping the old version of the article viewer around to view the legacy format or being able to transform the older article format to work with the new article view is still up for discussion.

Keeping the old page loading code around for a while is another valid option. It does come with the burden of keeping a lot of old code around and added complexity. On second thought, that might be still needed for the MW API fallback until Parsoid and RESTBase handle language variants correctly. Maybe keep track of how many pages are stored in the old saved pages format and report that via event logging?

Another option could be to add a converter in the page library or similar.