Page MenuHomePhabricator
Create Task
Maniphest T220036

Stop using jsonlint and instead use eslint-plugin-json for the linting
Open, Needs TriagePublic
Actions

Description

Using [[https://github.com/wikimedia/eslint-config-wikimedia/issues/166|upstream patch in eslint-config-wikimedia v0.12.0]] with local configuration.

Wikimedia production repos to fix:

  • extensions / ApiFeatureUsage
  • extensions / ArticlePlaceholder
  • extensions / BounceHandler
  • extensions / Calendar
  • extensions / Capiunto
  • extensions / CharInsert
  • extensions / cldr
  • extensions / CodeReview
  • extensions / Cognate
  • extensions / Collection
  • extensions / CommonsMetadata
  • extensions / CongressLookup
  • extensions / ContactPage (@Majavah)
  • extensions / CreditsSource
  • extensions / Dashiki
  • extensions / Disambiguator
  • extensions / DismissableSiteNotice
  • extensions / DoubleWiki
  • extensions / DynamicSidebar
  • extensions / EntitySchema
  • extensions / EventLogging
  • extensions / ExtensionDistributor
  • extensions / ExternalGuidance
  • extensions / FeaturedFeeds
  • extensions / FileExporter
  • extensions / FileImporter
  • extensions / FlaggedRevs
  • extensions / FundraiserLandingPage
  • extensions / FundraisingTranslateWorkflow
  • extensions / GeoCrumbs
  • extensions / GeoData
  • extensions / GettingStarted
  • extensions / GlobalBlocking
  • extensions / GlobalPreferences
  • extensions / GlobalUserPage
  • extensions / GoogleNewsSitemap
  • extensions / GrowthExperiments
  • extensions / GuidedTour
  • extensions / GWToolset
  • extensions / Insider (@Majavah)
  • extensions / intersection
  • extensions / InterwikiSorting
  • extensions / Jade
  • extensions / Josa
  • extensions / LandingCheck
  • extensions / LdapAuthentication
  • extensions / Linter
  • extensions / LiquidThreads
  • extensions / Listings
  • extensions / LoginNotify
  • extensions / MapSources
  • extensions / MassMessage
  • extensions / MobileApp
  • extensions / Newsletter
  • extensions / NewUserMessage (@Majavah)
  • extensions / OAuth
  • extensions / ORES
  • extensions / PagedTiffHandler
  • extensions / PageTriage
  • extensions / PageViewInfo
  • extensions / Petition
  • extensions / PoolCounter
  • extensions / QuickSurveys
  • extensions / Quiz
  • extensions / ReadingLists
  • extensions / RelatedArticles
  • extensions / RSS
  • extensions / SandboxLink
  • extensions / SearchExtraNS
  • extensions / SecureLinkFixer
  • extensions / SecurePoll
  • extensions / ShortUrl (@Majavah)
  • extensions / SubPageList3
  • extensions / SubpageSortkey
  • extensions / TemplateSandbox
  • extensions / TemplateStyles
  • extensions / TemplateWizard
  • extensions / TheWikipediaLibrary
  • extensions / timeline
  • extensions / TocTree
  • extensions / TorBlock
  • extensions / TranslationNotifications
  • extensions / TrustedXFF (@Majavah)
  • extensions / UploadsLink
  • extensions / WikibaseLexeme
  • extensions / WikibaseQualityConstraints
  • extensions / WikidataPageBanner
  • extensions / wikihiero
  • extensions / WikimediaBadges
  • extensions / WikimediaEditorTasks
  • extensions / WikimediaIncubator
  • extensions / Wikisource
  • skins / CologneBlue
  • skins / Modern
  • skins / MonoBook
  • skins / Nostalgia
  • skins / Timeless @RetroCraft

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Capiuntomaster+798 -261build: Replace jsonlint with eslint
mediawiki/skins/Nostalgiamaster+819 -281build: Replace jsonlint with eslint
mediawiki/extensions/EmailCapturemaster+1 K -200build: Replace jshint/jsonlint with eslint
mediawiki/extensions/EmailCapturemaster+1 K -153New version 0.5.0
mediawiki/extensions/PhpTagsStoragemaster+994 -407build: Replace jshint/jsonlint with eslint
mediawiki/extensions/OnlineStatusmaster+1 K -472build: Replace jshint/jsonlint with eslint
mediawiki/extensions/HTMLTagsmaster+1 K -200build: Replace jshint/jsonlint with eslint
mediawiki/extensions/PhpTagsmaster+995 -410build: Replace jshint/jsonlint with eslint
mediawiki/extensions/PhpHighlightmaster+995 -410build: Replace jshint/jsonlint with eslint
mediawiki/extensions/Insidermaster+837 -281build: Use ESLint instead of JSHint and JSONLint
mediawiki/extensions/ShortUrlmaster+579 -296build: Use ESLint instead of JSHint and JSONLint
mediawiki/extensions/PageBlockmaster+1 K -443build: Replace jshint/jsonlint with eslint
mediawiki/extensions/NewUserMessagemaster+5 -94build: Use ESLint for JSON linting, pin ESLint versions
mediawiki/extensions/TrustedXFFmaster+4 -30build: Use ESLint for JSON linting
mediawiki/extensions/FileExportermaster+872 -78build: Replace jsonlint with eslint
mediawiki/extensions/Cognatemaster+895 -79build: Replace jsonlint with eslint
mediawiki/extensions/FileImportermaster+853 -933build: Replace jsonhint, update eslint, update wdio
mediawiki/extensions/PrivateDomainsmaster+995 -410build: Replace jshint/jsonlint with eslint
mediawiki/extensions/PaginateTextmaster+1 K -216build: Replace jshint/jsonlint with eslint
mediawiki/extensions/PushToWatchmaster+816 -193build: Replace jshint/jsonlint with eslint
mediawiki/extensions/RandomPagesmaster+995 -409build: Replace jshint/jsonlint with eslint
mediawiki/extensions/RandomAreamaster+995 -409build: Replace jshint/jsonlint with eslint
mediawiki/extensions/PageLanguagemaster+995 -410build: Replace jshint/jsonlint with eslint
mediawiki/extensions/PageCreationNotifmaster+995 -410build: Replace jshint/jsonlint with eslint
mediawiki/skins/Timelessmaster+233 -201Remove jsonlint, upgrade eslint-config-wikimedia
mediawiki/extensions/CreateRedirectmaster+872 -297build: Replace jshint/jsonlint with eslint
mediawiki/extensions/Pollmaster+870 -285build: Replace jshint/jsonlint with eslint
mediawiki/extensions/HoverGallerymaster+3 K -254build: Replace jshint/jsonlint with eslint
mediawiki/extensions/GoogleAdSensemaster+894 -75build: Replace jshint/jsonlint with eslint
mediawiki/extensions/Calendarmaster+1 K -637build: Replace jshint/jsonlint with eslint, update dev dependencies
mediawiki/extensions/WebChatmaster+749 -1 Kbuild: Replace jshint/jsonlint with eslint
mediawiki/extensions/ContactPagemaster+6 -44build: Drop jsonlint and use ESLint for JSON linting instead
mediawiki/extensions/VisualEditormaster+1 -1Update VE core submodule to master (7e10b410b)
mediawiki/extensions/PropertySuggestermaster+21 -31build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Echomaster+7 -18build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/AntiSpoofmaster+6 -14build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/GlobalCssJsmaster+5 -13build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/CentralAuthmaster+7 -13build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/BetaFeaturesmaster+5 -14build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/CategoryTreemaster+9 -14build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/ContentTranslationmaster+7 -17build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/AbuseFiltermaster+4 -12build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Babelmaster+9 -17build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Campaignsmaster+7 -13build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Nukemaster+6 -14build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/3Dmaster+5 -14build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/coremaster+5 -12build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Citemaster+5 -17build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/CirrusSearchmaster+5 -14build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/skins/MinervaNeuemaster+4 -14build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/MobileFrontendmaster+4 -14build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/VisualEditormaster+5 -16build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
VisualEditor/VisualEditormaster+58 -92build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Majavah removed a project: User-Majavah.Dec 9 2019, 6:38 PM
Majavah updated the task description. (Show Details)
Majavah removed the point value for this task.
gerritbot added a comment.Dec 22 2019, 8:53 PM

Change 560090 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Calendar@master] build: Replace jshint/jsonlint with eslint, update dev dependencies

https://gerrit.wikimedia.org/r/560090

gerritbot added a comment.Dec 25 2019, 5:17 AM

Change 560553 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/WebChat@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560553

gerritbot added a comment.Dec 25 2019, 10:56 AM

Change 560553 merged by jenkins-bot:
[mediawiki/extensions/WebChat@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560553

gerritbot added a comment.Dec 25 2019, 11:54 AM

Change 560090 merged by jenkins-bot:
[mediawiki/extensions/Calendar@master] build: Replace jshint/jsonlint with eslint, update dev dependencies

https://gerrit.wikimedia.org/r/560090

gerritbot added a comment.Dec 25 2019, 10:55 PM

Change 560590 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Poll@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560590

gerritbot added a comment.Dec 26 2019, 9:08 PM

Change 560799 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/CreateRedirect@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560799

gerritbot added a comment.Dec 27 2019, 2:08 AM

Change 560811 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/EmailCapture@master] New version 0.5.0

https://gerrit.wikimedia.org/r/560811

gerritbot added a comment.Dec 28 2019, 9:26 AM

Change 560879 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/HoverGallery@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560879

gerritbot added a comment.Dec 28 2019, 9:52 AM

Change 560881 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/GoogleAdSense@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560881

gerritbot added a comment.Dec 28 2019, 10:38 AM

Change 560881 merged by jenkins-bot:
[mediawiki/extensions/GoogleAdSense@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560881

gerritbot added a comment.Dec 28 2019, 11:25 AM

Change 560879 merged by jenkins-bot:
[mediawiki/extensions/HoverGallery@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560879

gerritbot added a comment.Dec 28 2019, 12:15 PM

Change 560590 merged by jenkins-bot:
[mediawiki/extensions/Poll@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560590

gerritbot added a comment.Dec 28 2019, 12:17 PM

Change 560799 merged by jenkins-bot:
[mediawiki/extensions/CreateRedirect@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/560799

gerritbot added a comment.Jan 5 2020, 11:16 PM

Change 562073 had a related patch set uploaded (by RetroCraft; owner: RetroCraft):
[mediawiki/skins/Timeless@master] Remove jsonlint, upgrade eslint-config-wikimedia

https://gerrit.wikimedia.org/r/562073

RetroCraft added a subscriber: RetroCraft.Jan 5 2020, 11:21 PM

I've submitted a patch to Timeless, however the project was on an outdated version of eslint-config-wikimedia which did not yet include JSON linting. I upgraded eslint-config-wikimedia and grunt-eslint, but there are lint errors introduced by the config change (specifically, no-jquery/no-fade and no-jquery/no-global-selector). Is the best practice to just line-by-line eslint ignore the errors, file-by-file, or disable the rule entirely project-wide?

Jdforrester-WMF added a comment.Jan 6 2020, 5:52 PM
In T220036#5776882, @RetroCraft wrote:

I've submitted a patch to Timeless, however the project was on an outdated version of eslint-config-wikimedia which did not yet include JSON linting. I upgraded eslint-config-wikimedia and grunt-eslint, but there are lint errors introduced by the config change (specifically, no-jquery/no-fade and no-jquery/no-global-selector). Is the best practice to just line-by-line eslint ignore the errors, file-by-file, or disable the rule entirely project-wide?

If the usage is widespread in the code, disabling it project-wide is best. If there are only maybe five uses, disable it inline. We generally don't do file-level disables as they're confusing when moving code around. Thank you!

RetroCraft updated the task description. (Show Details)Jan 7 2020, 1:09 AM
gerritbot added a comment.Jan 7 2020, 6:23 PM

Change 562073 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Remove jsonlint, upgrade eslint-config-wikimedia

https://gerrit.wikimedia.org/r/562073

WMDE-Fisch added a subscriber: WMDE-Fisch.Jan 10 2020, 10:08 AM

I wonder, what to do with extensions, that currently do not use eslint and do not have any JS code. Should we still add eslint then "just" for the json checks?

gerritbot added a comment.Jan 10 2020, 2:04 PM

Change 563446 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PageCreationNotif@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563446

Jdforrester-WMF added a comment.Jan 10 2020, 4:29 PM
In T220036#5792110, @WMDE-Fisch wrote:

I wonder, what to do with extensions, that currently do not use eslint and do not have any JS code. Should we still add eslint then "just" for the json checks?

Yes.

gerritbot added a comment.Jan 10 2020, 7:27 PM

Change 563549 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PageLanguage@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563549

gerritbot added a comment.Jan 10 2020, 7:38 PM

Change 563446 merged by jenkins-bot:
[mediawiki/extensions/PageCreationNotif@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563446

gerritbot added a comment.Jan 10 2020, 8:04 PM

Change 563549 merged by jenkins-bot:
[mediawiki/extensions/PageLanguage@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563549

gerritbot added a comment.Jan 10 2020, 8:10 PM

Change 563569 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/RandomArea@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563569

gerritbot added a comment.Jan 10 2020, 8:14 PM

Change 563571 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/RandomPages@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563571

gerritbot added a comment.Jan 10 2020, 8:20 PM

Change 563569 merged by jenkins-bot:
[mediawiki/extensions/RandomArea@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563569

gerritbot added a comment.Jan 10 2020, 8:20 PM

Change 563571 merged by jenkins-bot:
[mediawiki/extensions/RandomPages@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563571

gerritbot added a comment.Jan 11 2020, 1:50 AM

Change 563627 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PaginateText@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563627

gerritbot added a comment.Jan 11 2020, 3:31 PM

Change 563675 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PhpHighlight@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563675

gerritbot added a comment.Jan 11 2020, 3:43 PM

Change 563677 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PhpTags@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563677

gerritbot added a comment.Jan 11 2020, 3:54 PM

Change 563679 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PhpTagsStorage@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563679

gerritbot added a comment.Jan 12 2020, 9:07 PM

Change 563732 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PrivateDomains@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563732

gerritbot added a comment.Jan 12 2020, 9:54 PM

Change 563739 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PushToWatch@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563739

gerritbot added a comment.Jan 12 2020, 9:57 PM

Change 563739 merged by jenkins-bot:
[mediawiki/extensions/PushToWatch@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563739

gerritbot added a comment.Jan 13 2020, 5:34 PM

Change 563627 merged by jenkins-bot:
[mediawiki/extensions/PaginateText@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563627

gerritbot added a comment.Jan 13 2020, 6:02 PM

Change 564075 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] build: Replace jsonhint, update eslint, update wdio conf

https://gerrit.wikimedia.org/r/564075

gerritbot added a comment.Jan 13 2020, 6:19 PM

Change 563732 merged by jenkins-bot:
[mediawiki/extensions/PrivateDomains@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563732

Umherirrender added a comment.Jan 13 2020, 7:04 PM

I just want note that grunt-jsonlint has get a major release to version 2 and supports indent check and pretty print check etc.
It seems it is not longer called "abandonware".

https://www.npmjs.com/package/grunt-jsonlint

gerritbot added a comment.Jan 13 2020, 7:07 PM

Change 564075 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] build: Replace jsonhint, update eslint, update wdio

https://gerrit.wikimedia.org/r/564075

Jdforrester-WMF added a comment.Jan 13 2020, 7:21 PM
In T220036#5799019, @Umherirrender wrote:

I just want note that grunt-jsonlint has get a major release to version 2 and supports indent check and pretty print check etc.
It seems it is not longer called "abandonware".

https://www.npmjs.com/package/grunt-jsonlint

Oh well, about a year too late.

Jdforrester-WMF renamed this task from Stop using jsonlint (as it's abandonware) and instead use eslint-plugin-json for the linting to Stop using jsonlint and instead use eslint-plugin-json for the linting.Jan 13 2020, 7:21 PM
gerritbot added a comment.Jan 13 2020, 7:36 PM

Change 564100 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileExporter@master] build: Replace jsonlint with eslint

https://gerrit.wikimedia.org/r/564100

gerritbot added a comment.Jan 13 2020, 9:19 PM

Change 564136 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/PageBlock@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/564136

gerritbot added a comment.Jan 14 2020, 9:15 AM

Change 564556 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Cognate@master] build: Replace jsonlint with eslint

https://gerrit.wikimedia.org/r/564556

gerritbot added a comment.Jan 14 2020, 11:17 AM

Change 564556 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] build: Replace jsonlint with eslint

https://gerrit.wikimedia.org/r/564556

gerritbot added a comment.Jan 14 2020, 4:44 PM

Change 564100 merged by jenkins-bot:
[mediawiki/extensions/FileExporter@master] build: Replace jsonlint with eslint

https://gerrit.wikimedia.org/r/564100

WMDE-Fisch updated the task description. (Show Details)Jan 15 2020, 9:51 AM
Majavah updated the task description. (Show Details)Jan 18 2020, 4:33 PM
gerritbot added a comment.Jan 18 2020, 4:39 PM

Change 565737 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/TrustedXFF@master] build: Use ESLint for JSON linting

https://gerrit.wikimedia.org/r/565737

gerritbot added a comment.Jan 18 2020, 9:58 PM

Change 565737 merged by jenkins-bot:
[mediawiki/extensions/TrustedXFF@master] build: Use ESLint for JSON linting

https://gerrit.wikimedia.org/r/565737

Majavah updated the task description. (Show Details)Jan 19 2020, 8:30 AM
Majavah updated the task description. (Show Details)Jan 20 2020, 2:22 PM
gerritbot added a comment.Jan 20 2020, 2:28 PM

Change 566040 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/NewUserMessage@master] build: Use ESLint for JSON linting, pin ESLint versions

https://gerrit.wikimedia.org/r/566040

gerritbot added a comment.Jan 20 2020, 5:06 PM

Change 566040 merged by jenkins-bot:
[mediawiki/extensions/NewUserMessage@master] build: Use ESLint for JSON linting, pin ESLint versions

https://gerrit.wikimedia.org/r/566040

Majavah updated the task description. (Show Details)Jan 20 2020, 5:11 PM
Majavah updated the task description. (Show Details)Jan 20 2020, 6:59 PM
gerritbot added a comment.Jan 20 2020, 6:59 PM

Change 566084 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/ShortUrl@master] build: Use ESLint instead of JSHint and JSONLint

https://gerrit.wikimedia.org/r/566084

gerritbot added a comment.Jan 21 2020, 7:06 AM

Change 564136 merged by jenkins-bot:
[mediawiki/extensions/PageBlock@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/564136

gerritbot added a comment.Jan 21 2020, 3:06 PM

Change 566294 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/Insider@master] build: Use ESLint instead of JSHint and JSONLint

https://gerrit.wikimedia.org/r/566294

Jdforrester-WMF updated the task description. (Show Details)Jan 21 2020, 4:39 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Jan 21 2020, 4:42 PM

Change 566084 merged by jenkins-bot:
[mediawiki/extensions/ShortUrl@master] build: Use ESLint instead of JSHint and JSONLint

https://gerrit.wikimedia.org/r/566084

gerritbot added a comment.Jan 21 2020, 4:44 PM

Change 566294 merged by jenkins-bot:
[mediawiki/extensions/Insider@master] build: Use ESLint instead of JSHint and JSONLint

https://gerrit.wikimedia.org/r/566294

gerritbot added a comment.Jan 21 2020, 4:54 PM

Change 563675 merged by jenkins-bot:
[mediawiki/extensions/PhpHighlight@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563675

gerritbot added a comment.Jan 21 2020, 4:55 PM

Change 563677 merged by jenkins-bot:
[mediawiki/extensions/PhpTags@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563677

gerritbot added a comment.Jan 22 2020, 10:16 PM

Change 566608 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/HTMLTags@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/566608

gerritbot added a comment.Jan 23 2020, 2:41 AM

Change 566608 merged by jenkins-bot:
[mediawiki/extensions/HTMLTags@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/566608

gerritbot added a comment.Jan 25 2020, 3:29 PM

Change 567248 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/OnlineStatus@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/567248

gerritbot added a comment.Feb 1 2020, 9:38 AM

Change 567248 merged by jenkins-bot:
[mediawiki/extensions/OnlineStatus@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/567248

gerritbot added a comment.Feb 1 2020, 10:05 AM

Change 563679 merged by Umherirrender:
[mediawiki/extensions/PhpTagsStorage@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/563679

gerritbot added a comment.Feb 5 2020, 2:01 AM

Change 560811 abandoned by Zoranzoki21:
New version 0.5.0

Reason:
Will make new

https://gerrit.wikimedia.org/r/560811

gerritbot added a comment.Feb 5 2020, 2:09 AM

Change 570183 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/EmailCapture@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/570183

gerritbot added a comment.Feb 5 2020, 8:19 PM

Change 570183 merged by jenkins-bot:
[mediawiki/extensions/EmailCapture@master] build: Replace jshint/jsonlint with eslint

https://gerrit.wikimedia.org/r/570183

gerritbot added a comment.Mar 16 2020, 3:20 PM

Change 579852 had a related patch set uploaded (by Jforrester; owner: Zoranzoki21):
[mediawiki/skins/Nostalgia@master] build: Replace jsonlint with eslint

https://gerrit.wikimedia.org/r/579852

gerritbot added a comment.Mar 16 2020, 4:11 PM

Change 579852 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] build: Replace jsonlint with eslint

https://gerrit.wikimedia.org/r/579852

gerritbot added a comment.Mar 16 2020, 5:34 PM

Change 579820 had a related patch set uploaded (by Jforrester; owner: Zoranzoki21):
[mediawiki/extensions/Capiunto@master] build: Replace jsonlint with eslint

https://gerrit.wikimedia.org/r/579820

gerritbot added a comment.Mar 18 2020, 7:58 PM

Change 579820 merged by jenkins-bot:
[mediawiki/extensions/Capiunto@master] build: Replace jsonlint with eslint

https://gerrit.wikimedia.org/r/579820

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL