Page MenuHomePhabricator

Stop using jsonlint (as it's abandonware) and instead use eslint-plugin-json for the linting
Open, Needs TriagePublic0 Story Points

Description

Using upstream patch in eslint-config-wikimedia v0.12.0 with local configuration.

Wikimedia production repos to fix:

  • MediaWiki
  • extensions / 3D
  • extensions / AbuseFilter
  • extensions / ActiveAbstract
  • extensions / AdvancedSearch
  • extensions / AntiSpoof
  • extensions / ApiFeatureUsage
  • extensions / ArticleCreationWorkflow
  • extensions / ArticlePlaceholder
  • extensions / Babel
  • extensions / BetaFeatures
  • extensions / BounceHandler
  • extensions / Calendar
  • extensions / Campaigns
  • extensions / Capiunto
  • extensions / CategoryTree
  • extensions / CentralAuth
  • extensions / CharInsert
  • extensions / CheckUser
  • extensions / CirrusSearch
  • extensions / Cite
  • extensions / CiteThisPage
  • extensions / Citoid
  • extensions / cldr
  • extensions / CodeEditor
  • extensions / CodeReview
  • extensions / CodeMirror
  • extensions / Cognate
  • extensions / CollaborationKit
  • extensions / Collection
  • extensions / CommonsMetadata
  • extensions / ConfirmEdit
  • extensions / CongressLookup
  • extensions / ContactPage
  • extensions / ContentTranslation
  • extensions / ContributionTracking
  • extensions / CreditsSource
  • extensions / Dashiki
  • extensions / Disambiguator
  • extensions / DismissableSiteNotice
  • extensions / DonationInterface
  • extensions / DoubleWiki
  • extensions / DynamicSidebar
  • extensions / Echo
  • extensions / Elastica
  • extensions / ElectronPdfService
  • extensions / EntitySchema
  • extensions / EUCopyrightCampaign
  • extensions / EventBus
  • extensions / EventLogging
  • extensions / ExtensionDistributor
  • extensions / ExternalGuidance
  • extensions / FeaturedFeeds
  • extensions / FileExporter
  • extensions / FileImporter
  • extensions / FlaggedRevs
  • extensions / Flow
  • extensions / FundraiserLandingPage
  • extensions / FundraisingTranslateWorkflow
  • extensions / Gadgets
  • extensions / GeoCrumbs
  • extensions / GeoData
  • extensions / GettingStarted
  • extensions / GlobalBlocking
  • extensions / GlobalCssJs
  • extensions / GlobalPreferences
  • extensions / GlobalUsage
  • extensions / GlobalUserPage
  • extensions / GoogleNewsSitemap
  • extensions / Graph
  • extensions / GrowthExperiments
  • extensions / GuidedTour
  • extensions / GWToolset
  • extensions / ImageMap
  • extensions / InputBox
  • extensions / Insider
  • extensions / intersection
  • extensions / Interwiki
  • extensions / InterwikiSorting
  • extensions / JADE
  • extensions / Josa
  • extensions / JsonConfig
  • extensions / Kartographer
  • extensions / LabeledSectionTransclusion
  • extensions / LandingCheck
  • extensions / LdapAuthentication
  • extensions / Linter
  • extensions / LiquidThreads
  • extensions / Listings
  • extensions / LocalisationUpdate
  • extensions / LoginNotify
  • extensions / MapSources
  • extensions / MassMessage
  • extensions / Math
  • extensions / MobileApp
  • extensions / MobileFrontend
  • extensions / MultimediaViewer
  • extensions / Newsletter
  • extensions / NewUserMessage
  • extensions / Nuke
  • extensions / OATHAuth
  • extensions / OAuth
  • extensions / OpenStackManager
  • extensions / ORES
  • extensions / PageAssessments
  • extensions / PagedTiffHandler
  • extensions / PageImages
  • extensions / PageTriage
  • extensions / PageViewInfo
  • extensions / ParserFunctions
  • extensions / ParsoidBatchAPI
  • extensions / PdfHandler
  • extensions / PerformanceInspector
  • extensions / Petition
  • extensions / Poem
  • extensions / PoolCounter
  • extensions / Popups
  • extensions / ProofreadPage
  • extensions / PropertySuggester
  • extensions / QuickSurveys
  • extensions / Quiz
  • extensions / ReadingLists
  • extensions / RelatedArticles
  • extensions / Renameuser
  • extensions / RevisionSlider
  • extensions / RSS
  • extensions / SandboxLink
  • extensions / Score
  • extensions / Scribunto
  • extensions / SearchExtraNS
  • extensions / SecurePoll
  • extensions / Sentry
  • extensions / ShortUrl
  • extensions / SiteMatrix
  • extensions / SkinPerPage
  • extensions / SpamBlacklist
  • extensions / SubPageList3
  • extensions / SubpageSortkey
  • extensions / SyntaxHighlight_GeSHi
  • extensions / TemplateData
  • extensions / TemplateSandbox
  • extensions / TemplateStyles
  • extensions / TemplateWizard
  • extensions / TextExtracts
  • extensions / Thanks
  • extensions / TimedMediaHandler
  • extensions / timeline
  • extensions / TitleBlacklist
  • extensions / TocTree
  • extensions / TorBlock
  • extensions / Translate
  • extensions / TranslationNotifications
  • extensions / TrustedXFF
  • extensions / TwoColConflict
  • extensions / UniversalLanguageSelector
  • extensions / UploadsLink
  • extensions / UploadWizard
  • extensions / UrlShortener
  • extensions / UserMerge
  • extensions / VisualEditor
  • extensions / Wikibase
  • extensions / WikibaseLexeme
  • extensions / WikibaseMediaInfo
  • extensions / WikibaseQualityConstraints
  • extensions / Wikidata.org
  • extensions / WikidataPageBanner
  • extensions / WikiEditor
  • extensions / wikihiero
  • extensions / WikiLove
  • extensions / WikimediaBadges
  • extensions / WikimediaEditorTasks
  • extensions / WikimediaEvents
  • extensions / WikimediaIncubator
  • extensions / WikimediaMaintenance
  • extensions / WikimediaMessages
  • extensions / XAnalytics
  • extensions / ZeroBanner
  • extensions / ZeroPortal
  • skins / CologneBlue
  • skins / EUCopyrightCampaignSkin
  • skins / Modern
  • skins / MinervaNeue
  • skins / MonoBook
  • skins / Nostalgia
  • skins / Timeless
  • skins / Vector
  • OOUI
  • VisualEditor

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (7e10b410b)
mediawiki/extensions/PropertySuggester : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Echo : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/AntiSpoof : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/GlobalCssJs : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/CentralAuth : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/BetaFeatures : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/CategoryTree : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/ContentTranslation : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/AbuseFilter : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Babel : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Campaigns : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Nuke : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/3D : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/core : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/Cite : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/CirrusSearch : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/skins/MinervaNeue : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/MobileFrontend : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
mediawiki/extensions/VisualEditor : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint
VisualEditor/VisualEditor : masterbuild: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2019, 8:03 PM
Krinkle moved this task from Inbox to Checkers on the MediaWiki-Core-Testing board.Apr 5 2019, 3:51 PM

Change 508398 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[VisualEditor/VisualEditor@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508398

Change 508400 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508400

Change 508402 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MobileFrontend@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508402

Change 508398 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508398

Change 508404 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508404

Change 508407 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/skins/MinervaNeue@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508407

Change 508409 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/AbuseFilter@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508409

Change 508413 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/3D@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508413

Change 508400 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508400

Change 508425 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/AntiSpoof@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508425

Change 508426 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Babel@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508426

Change 508428 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/BetaFeatures@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508428

Change 508432 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Campaigns@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508432

Change 508433 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CategoryTree@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508433

Change 508435 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CentralAuth@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508435

Change 508438 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CirrusSearch@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508438

Change 508440 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Cite@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508440

Change 508446 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/ContentTranslation@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508446

Change 508450 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Echo@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508450

Change 508402 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508402

Change 508459 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/GlobalCssJs@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508459

Change 508407 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508407

Change 508438 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508438

Change 508440 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508440

Change 508482 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Nuke@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508482

Change 508404 merged by jenkins-bot:
[mediawiki/core@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508404

Change 508413 merged by jenkins-bot:
[mediawiki/extensions/3D@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508413

Change 508482 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508482

Change 508409 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508409

Change 508426 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508426

Change 508432 merged by jenkins-bot:
[mediawiki/extensions/Campaigns@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508432

Change 508446 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508446

Change 508433 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508433

Change 508428 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508428

Change 508435 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508435

Change 508459 merged by jenkins-bot:
[mediawiki/extensions/GlobalCssJs@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508459

Change 508425 merged by jenkins-bot:
[mediawiki/extensions/AntiSpoof@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508425

Jdforrester-WMF updated the task description. (Show Details)

Change 508638 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/PropertySuggester@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508638

Change 508450 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508450

Change 508638 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint

https://gerrit.wikimedia.org/r/508638

Change 509127 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e10b410b)

https://gerrit.wikimedia.org/r/509127

Change 509127 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7e10b410b)

https://gerrit.wikimedia.org/r/509127

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptFri, Nov 1, 11:23 PM

@Jdforrester-WMF Do you plan to mentor this tasks?

@Jdforrester-WMF Do you plan to mentor this tasks?

Happy to, yes.

I've invited you into the GCI interface then, James!

James offered to mentor this. @Jdforrester-WMF: Feel free to import this into https://codein.withgoogle.com yourself. Feel free to ask me if you have any questions.