We forgot to include the lang parameter when writing the code to automate access code emails, in addition to the translate tags in the email. As such, all access code emails will currently send in English. This needs to be updated to be in line with other emails.
The formatting for doing this can be found in the other email templates: https://github.com/WikipediaLibrary/TWLight/tree/master/TWLight/emails/templates/emails
- The templates which need updating are the ones which start access_code_email in https://github.com/WikipediaLibrary/TWLight/tree/master/TWLight/emails/templates/emails. It looks like the subject was correctly tagged for translation, but the body html and text were not.
- Additionally, the lang parameter needs to be passed in at https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/emails/tasks.py#L364. See https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/emails/tasks.py#L261 for an example of this elsewhere in an email. We need to set lang to instance.authorization.user.userprofile.lang
Good first bug
This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.
If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.
If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!
How to contribute
Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!
To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted. Experienced contributors to the project will review your code and either provide feedback or merge it in!