Page MenuHomePhabricator

Tag access code emails for translation
Closed, ResolvedPublicBUG REPORT

Description

Task

We forgot to include the lang parameter when writing the code to automate access code emails, in addition to the translate tags in the email. As such, all access code emails will currently send in English. This needs to be updated to be in line with other emails.

The formatting for doing this can be found in the other email templates: https://github.com/WikipediaLibrary/TWLight/tree/master/TWLight/emails/templates/emails

Good first bug

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedBUG REPORTSoumyaa1804

Event Timeline

Samwalton9 triaged this task as Medium priority.Jun 26 2019, 2:02 PM
Samwalton9 renamed this task from Access code emails don't translate to Tag access code emails for translation.Nov 6 2019, 11:05 AM
Samwalton9 updated the task description. (Show Details)

Hi! This is my first open-source project. I want to know what are the name conventions Wikimedia use for naming branches?

Hi! An ideal name for the branch would be the Phabricator ID, in this case T220087 :)

Welcome! Looking forward to contributing more to Wikimedia. :)

@Soumyaa1804 If you'd like a suggestion for another task to take up, we have more tagged with good first task, which you can find listed at https://phabricator.wikimedia.org/project/board/2765/query/rCNFr9ipmEnt/ :)

Sure @Samwalton9 Can you please help me in running TWLight project on my local machine? It's Linux-mint 18.3
Till now, I have:
Forked and Cloned the repository https://github.com/WikipediaLibrary/TWLight
Connected it to the upstream

Inside the cloned repository, I installed docker and docker-compose. Their versions are as follows:
docker-compose --version
docker-compose version 1.17.0, build ac53b73
docker --version
Docker version 19.03.5, build 633a0ea838

Then I tried to run
docker-compose build && docker-compose up
which is giving an error.

Successfully built 202830511178
Successfully tagged wikipedialibrary/twlight:local
web uses an image, skipping
Starting twlight_db_1 ...
Starting twlight_db_1 ... error

ERROR: for twlight_db_1 Cannot start service db: driver failed programming external connectivity on endpoint twlight_db_1 (a0aed9e7f7cada86267908487c075e3da0b36b2141bda0c9d6bd0f39285d67d1): Error starting userland proxy: listen tcp 0.0.0.0:3306: bind: address already in use

ERROR: for db Cannot start service db: driver failed programming external connectivity on endpoint twlight_db_1 (a0aed9e7f7cada86267908487c075e3da0b36b2141bda0c9d6bd0f39285d67d1): Error starting userland proxy: listen tcp 0.0.0.0:3306: bind: address already in use
ERROR: Encountered errors while bringing up the project.

I am not familiar with docker. Please help.

@Soumyaa1804 That looks like you already have a service running on port 3306, probably MySQL. If that service is currently running on your machine then the TWLight database can't also come up. Stopping your local service should fix this, via something like service mysql stop :)

It worked! Thanks.
Now it's working on localhost. On moving further with instructions on https://github.com/WikipediaLibrary/TWLight/blob/master/docs/developer.md, I ran this command inside the bin folder:
docker exec twlight virtualenv_migrate.sh
It is showing
No such container: twlight
I checked the containers with the command:
docker container ls
It gave names of 3 containers: twlight_web_1, twlight_twlight_1, twlight_db_1
What to do?

Great! Our documentation really needs updating, so sorry that it's not totally useful.

I think that should be docker-compose exec twlight virtualenv_migrate.sh. Let me know if that works for you :)

In the bin folder:
docker-compose exec twlight virtualenv_migrate.sh
OCI runtime exec failed: exec failed: container_linux.go:346: starting container process caused "exec: \"virtualenv_migrate.sh\": executable file not found in $PATH": unknown

Oh yep, wow that documentation really is bad. It should be docker-compose exec twlight /app/bin/virtualenv_migrate.sh

Finally! It all set. This command worked.
Also, docker-compose exec twlight /app/bin/virtualenv_example_data.sh is going great.
Thanks a ton!
About the documentation part, can I do something about it? Like creating an issue and changing the command from:
docker exec twlight virtualenv_migrate.sh
to
docker-compose exec twlight /app/bin/virtualenv_migrate.sh

Let me know your suggestions. :)

That would be super appreciated, yes! :)