Page MenuHomePhabricator

Remove deprecated "ve-test-toolbar-" classes
Closed, ResolvedPublic

Description

In JS these can be replaced by toolbar.groupsByName, e.g.

$( '.ve-test-toolbar-format' );
// Becomes...
ve.init.target.toolbar.groupsByName.format.$element;

In CSS these can be replaced by ve-ui-toolbar-group- but that should be upstreamed to OOUI.

mwgrep "ve-test-toolbar-"
arwiki              MediaWiki:Common.css
arwikiquote         MediaWiki:Common.css
frwiki              MediaWiki:Guidedtour-tour-tuto14.js
frwiki              MediaWiki:Guidedtour-tour-tuto6.js
frwiki              MediaWiki:Guidedtour-tour-wikifundi21c.js
frwiki              MediaWiki:Guidedtour-tour-wikimooc21c.js
frwiki              MediaWiki:Guidedtour-tour-wikimooc51c.js
iswiki              MediaWiki:Guidedtour-tour-newpage.js
pswiki              MediaWiki:Common.css

https://codesearch.wmflabs.org/search/?q=ve-test-toolbar-&i=nope&files=&repos= (no results)

Event Timeline

Esanders updated the task description. (Show Details)

Change 501194 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Remove deprecated ve-test-toolbar- classes

https://gerrit.wikimedia.org/r/501194

All on-wiki uses have been renamed to ve-ui-toolbar-group- so the above patch can be merged.

We should try to avoid using the CSS selector in JS.

Change 501194 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove deprecated ve-test-toolbar- classes

https://gerrit.wikimedia.org/r/501194

Change 501431 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8653ce4bd)

https://gerrit.wikimedia.org/r/501431

Change 501431 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8653ce4bd)

https://gerrit.wikimedia.org/r/501431