Page MenuHomePhabricator

Reference previews broken on gendered namespace aliases
Closed, ResolvedPublic3 Story Points

Description

Bug report
When using reference on a page inside of an gendered user namespace ( e.g. Benutzerin for de ) the reference preview does not work. Instead it seems that a page preview is triggered.

Acceptance Criteria

  • ReferencePreviews also work on pages in the user namespace that are gendered

Notes
ReferencePreviews check validity of the link, and apparently the namespace alias confuses the validation.

Event Timeline

WMDE-Fisch renamed this task from Reference previews on namespace gender aliases to Reference previews broken on gendered aliases namespace .
WMDE-Fisch renamed this task from Reference previews broken on gendered aliases namespace to Reference previews broken on gendered namespace aliases.
Lea_WMDE triaged this task as Normal priority.Apr 10 2019, 3:38 PM
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE set the point value for this task to 3.
WMDE-Fisch claimed this task.

The root of the problem seems to be this: T221372: mw.Title.getNamespacePrefix() does not work with namespaceGenderAliases. Although we might be able to fix it differently.

Change 504886 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Use tite and namespace id to check if link is current page

https://gerrit.wikimedia.org/r/504886

Change 506637 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Minimize createStubTitle() helper method

https://gerrit.wikimedia.org/r/506637

Change 504886 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Use title and namespace id to check if link is current page

https://gerrit.wikimedia.org/r/504886

Change 506654 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Use title.getNameText() to compare selflinks

https://gerrit.wikimedia.org/r/506654

Change 506654 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Use title.getNameText() to compare selflinks

https://gerrit.wikimedia.org/r/506654

Change 506637 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Minimize createStubTitle() helper method

https://gerrit.wikimedia.org/r/506637

Can be tested on de.beta when creating references on the user page and changing the user's gender to female so Benutzerin: shows as namespace.

Lea_WMDE closed this task as Resolved.May 6 2019, 3:21 PM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-04-17 board.