Page MenuHomePhabricator
Create Task
Maniphest T220113

Add php integration tests for Depicts
Closed, ResolvedPublic
Actions

Description

We currently don’t have tests for api calls used in depicts

Why do we need it?

  • This is basic functionality we need covered in tests

What should be tested:

  • add a depicts claim
  • edit a depicts claim prominence
  • delete a depicts claim
  • get all existing depicts claims for entity
  • search/lookup depicts items

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseMediaInfomaster+377 -114Integration tests for statements
Customize query in gerrit

Related Objects

Event Timeline

Ha78na created this task.Apr 4 2019, 2:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2019, 2:09 PM
Ha78na added a project: Structured-Data-Team-Current-Work.Apr 4 2019, 2:12 PM
Ha78na removed a subscriber: Aklapper.
Ha78na moved this task from To Do to Doing on the Structured-Data-Team-Current-Work board.Apr 4 2019, 3:33 PM
Ramsey-WMF triaged this task as Medium priority.Apr 4 2019, 4:59 PM
Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.
Ramsey-WMF added projects: SDC-Statements (Depicts-Crawling), Structured Data Engineering.
Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.
gerritbot added a comment.Apr 10 2019, 7:27 PM

Change 502867 had a related patch set uploaded (by Ha78na; owner: Ha78na):
[mediawiki/extensions/WikibaseMediaInfo@master] [WIP] phpunit integration tests

https://gerrit.wikimedia.org/r/502867

gerritbot added a project: Patch-For-Review.Apr 10 2019, 7:27 PM
Ha78na mentioned this in rEWBIdc9a633857d6: [WIP] phpunit integration tests.Apr 10 2019, 7:27 PM
Ha78na reassigned this task from Ha78na to Cparle.Apr 10 2019, 7:28 PM
Ha78na mentioned this in rEWBIe1d990b9dddf: [WIP] phpunit integration tests.Apr 10 2019, 8:46 PM
Cparle moved this task from Doing to Code Review on the Structured-Data-Team-Current-Work board.May 7 2019, 11:20 AM
Cparle removed a project: SDC-Statements (Depicts-Crawling).May 9 2019, 10:55 AM
gerritbot added a comment.May 28 2019, 4:08 PM

Change 502867 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Integration tests for statements

https://gerrit.wikimedia.org/r/502867

Maintenance_bot removed a project: Patch-For-Review.May 28 2019, 4:10 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).May 28 2019, 5:00 PM
Cparle added a comment.May 30 2019, 11:45 AM

This can't be reasonably QAd. Merged, so closing

Cparle closed this task as Resolved.May 30 2019, 11:45 AM
Cparle updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL