Maniphest T220159

Inline templates for mobile editor
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 4 2019, 10:28 PM

Description

Th editor makes use of several templates loaded via ResourceLoader. We will load them inline.

These are:

358:				"AbuseFilterOverlay.hogan": "resources/mobile.editor.overlay/AbuseFilterOverlay.hogan",
359:				"AbuseFilterPanel.hogan": "resources/mobile.editor.overlay/AbuseFilterPanel.hogan",
360:				"editHeader.hogan": "resources/mobile.editor.overlay/editHeader.hogan",
361:				"previewHeader.hogan": "resources/mobile.editor.overlay/previewHeader.hogan",
362:				"saveHeader.hogan": "resources/mobile.editor.overlay/saveHeader.hogan",
363:				"EditorOverlayBase.hogan": "resources/mobile.editor.overlay/EditorOverlayBase.hogan",
364:				"contentVE.hogan": "resources/mobile.editor.overlay/contentVE.hogan",
365:				"toolbarVE.hogan": "resources/mobile.editor.overlay/toolbarVE.hogan",
366:				"BlockMessage.hogan": "resources/mobile.editor.overlay/BlockMessage.hogan",
367:				"content.hogan": "resources/mobile.editor.overlay/content.hogan"

Acceptance criteria

All the files in the editor have been inlined.
Increase in JS bundlesizes should be consistent with the removal of the size of ResourceLoader's mobile.startup module. Change in bytes shipped to client should be recorded.

QA steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain
Click on the edit icon
Verify that the editor Overlay appears. Click the pencil icon and make sure you can successfully switch between "Visual editing" and "Source editing"
Click on "Source editing"
Type something new into the text box and click "Next"
Verify that the preview overlay appears that has a toolbar containing a "Publish" button

QA Results

AC	Status	Details
1	✅	T220159#5133290
2	✅	T220159#5133290
3	✅	T220159#5133290

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Inline mobile.editor templates	mediawiki/extensions/MobileFrontend	master	+160 -160

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved	Jdlrobson	T127268 Dismantle ResourceLoader's "targets" system
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	Jdlrobson	T195482 [EPIC] Review and refactor MobileFrontend components used by Minerva
Resolved	Jdlrobson	T166905 [EPIC] Talk about and improve our frontend code architecture
Resolved	pmiazga	T94086 [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates
Resolved	ovasileva	T220159 Inline templates for mobile editor

Event Timeline

Jdlrobson created this task.Apr 4 2019, 10:28 PM

Jdlrobson triaged this task as High priority.

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog-Archived board.

Jdlrobson renamed this task from Inline mobile.special page templates for Special:Nearby and Special:Uploads to Inline templates for mobile editor.Apr 4 2019, 10:34 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson edited parent tasks, added: T94086: [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates; removed: T217814: Nearby isn't a WatchstarPageList. Nearby has a WatchstarPageList..

ovasileva set the point value for this task to 3.Apr 9 2019, 4:39 PM

ovasileva edited projects, added Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog-Archived.

• nray claimed this task.Apr 9 2019, 5:11 PM

• nray moved this task from To Do to Doing on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.

Change 502656 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Inline mobile.editor templates

https://gerrit.wikimedia.org/r/502656

gerritbot added a project: Patch-For-Review.Apr 10 2019, 12:34 AM

• nray moved this task from Doing to Needs Code Review on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.Apr 10 2019, 12:57 AM

Change 502656 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Inline mobile.editor templates

https://gerrit.wikimedia.org/r/502656

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.Apr 10 2019, 8:35 PM

• nray reassigned this task from • nray to Edtadros.Apr 10 2019, 8:45 PM

• nray subscribed.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Apr 10 2019, 9:01 PM

@nray This needs QA steps.

Edtadros moved this task from Needs QA to Needs More Work on the Web-Team-Backlog-Archived (Readers-Web-Kanbanana-Board-2018-19-Q4) board.Apr 14 2019, 9:23 PM

In T220159#5110028, @Edtadros wrote:

@nray This needs QA steps.

Sorry! Added some steps now

@nray Thanks for the QA steps!

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

QA steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain
Click on the edit icon
✅ AC1: Verify that the editor Overlay appears.

✅ AC2: Click the pencil icon and make sure you can successfully switch between "Visual editing" and "Source editing"

Click on "Source editing"
Type something new into the text box and click "Next"
✅ AC3: Verify that the preview overlay appears that has a toolbar containing a "Publish" button

Edtadros updated the task description. (Show Details)Apr 23 2019, 11:25 PM

Edtadros added a project: Product-QA (RW-Test-Cases).Apr 25 2019, 9:49 PM

phuedx updated the task description. (Show Details)Apr 29 2019, 3:07 PM

Increase in JS bundlesizes should be consistent with the removal of the size of ResourceLoader's mobile.startup module. Change in bytes shipped to client should be recorded.

$ curl -H "Accept-Encoding: gzip" -I "https://en.m.wikipedia.org/w/load.php?lang=en&modules=startup&only=scripts&skin=minerva&target=mobile"
...
content-length: 22472
content-encoding: gzip

$ curl -H "Accept-Encoding: gzip" "https://en.m.wikipedia.org/w/load.php?lang=en&modules=mobile.editor.overlay&only=scripts&skin=minerva&target=mobile" | wc -l
6582

Unfortunately, the Performance team doesn't appear to track RL module size over time – they do have other per-module metrics though: https://grafana.wikimedia.org/d/000000067/resourceloadermodule

phuedx closed this task as Resolved.Apr 29 2019, 3:34 PM

phuedx updated the task description. (Show Details)

ovasileva moved this task from Backlog to Advanced Mobile Contributions on the Product-QA (RW-Test-Cases) board.Mar 2 2020, 6:39 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2020, 7:12 PM

	F28747318: T220159-3.png
	Apr 23 2019, 11:24 PM

	F28747317: T220159-2.png
	Apr 23 2019, 11:24 PM

	F28747319: T220159-1.png
	Apr 23 2019, 11:24 PM

Inline templates for mobile editorClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Acceptance criteria

QA steps

QA Results

Details

Related ObjectsSearch...

Event Timeline

Test Result

QA steps

Inline templates for mobile editor
Closed, ResolvedPublic3 Estimated Story Points
Actions

Related Objects
Search...