Just to clarify, if Echo is not enabled, then the checkboxes will not be there, correct? or would there be a single checkbox?

In T220163#5119726, @dbarratt wrote:

Just to clarify, if Echo is not enabled, then the checkboxes will not be there, correct? or would there be a single checkbox?

There will be a single checkbox. I'll add that to the description. :)

Can we change the text of the "Mute user" button to just "Save"? The reason being, that if the user is unumutting a user, then they uncheck the box and then click "Mute user"? seems odd. :)

In T220163#5119744, @dbarratt wrote:

Can we change the text of the "Mute user" button to just "Save"? The reason being, that if the user is unumutting a user, then they uncheck the box and then click "Mute user"? seems odd. :)

Oh, good point. I'll update it. Thanks for catching that!

Change 520050 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] [WIP] Add support for extentions to modify page form

https://gerrit.wikimedia.org/r/520050

Change 520051 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/Echo@master] [WIP] Add Special:Mute notification blacklist through a Hook

https://gerrit.wikimedia.org/r/520051

@Niharika this task introduces a few changes that conflict with the error messages we added on T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser

For instance, we used to show the message below as an error page but if there is a second option like "Mute Notifications" it doesn't make sense to do that anymore.

`You must confirm your email address before you can mute a user. You may do so from Special:Preferences.`

I suggest that we get rid of all the error messages that arise from accessing the page with the wrong configs and add only a generic one if there are no options on the form. Suggestions welcome for this message
As to the option Mute emails from this user, I would say to only display it when all the conditions are met, meaning when wgEnableUserEmailBlacklist, wgEnableUserEmail are true and the user has confirmed their email address.

@dmaza Okay. Thinking about how the generic message can be most useful/informational to the user. Here's my sense of when there will be no options on the form -

• Echo is not installed AND
• Email address is not confirmed OR emails are disabled OR email blacklist is disabled in Special:Prefs

Am I missing a scenario?
If that is correct, we can say:

Mute features are unavailable. This might be because: you haven't confirmed your email address, your email blacklist is disabled in [[Special:Preferences]] or the wiki administrator has disabled email features for this wiki.

What do you think?

As to the option Mute emails from this user, I would say to only display it when all the conditions are met, meaning when wgEnableUserEmailBlacklist, wgEnableUserEmail are true and the user has confirmed their email address.

Agreed.

Instead of saying "Mute emails from this user" and "Mute emails from this user" would it be better to say: "Mute emails from user ABC" and "Mute notifications from user ABC"?

I was just wondering because when I first come to the page, my brain skips the first line entirely and I read the options, which use this and then I have to figure out what this is.

In T220163#5322863, @dbarratt wrote:

Instead of saying "Mute emails from this user" and "Mute emails from this user" would it be better to say: "Mute emails from user ABC" and "Mute notifications from user ABC"?

I was just wondering because when I first come to the page, my brain skips the first line entirely and I read the options, which use this and then I have to figure out what this is.

IMO it looks a bit repetitive to keep mentioning "user ABC" on the form fields. Maybe we could update the page header instead to make it more "in your face" that you are muting user ABC. What do you think @Niharika? But to be honest, if a user takes action on a form without reading what it is about or understanding it, there isn't much we can do

@dmaza @dbarratt I agree it seems repetitive. We can make the user's name bold in the sentence above to make it a bit more prominent but let's go with ...from this user for now.

In T220163#5326499, @Niharika wrote:

@dmaza @dbarratt I agree it seems repetitive. We can make the user's name bold in the sentence above to make it a bit more prominent but let's go with ...from this user for now.

Sounds good to me

Change 520050 merged by Dbarratt:
[mediawiki/core@master] Add support for extentions to change Special:Mute form

https://gerrit.wikimedia.org/r/520050

Change 520051 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Add option to mute/unmute notifications on Special:Mute

https://gerrit.wikimedia.org/r/520051

Special:Mute adds and removes from the user_properties table (also visible in Special:Preferences#mw-prefsection-echo).

Checked that it sets the mute globally (if configured) or locally (if locally overridden) as appropriate.

Tried different combinations of truth values for $wgEnableUserEmailBlacklist and $wgEchoPerUserBlacklist. Appears to work fine with one or both set to true.

You can "globally" mute a user with the config. variable $wgEchoAgentBlacklist (see). This fact is not reflected in either Special:Mute/Hugh or Special:Preferences. But muting the same user with Special:Mute appears harmless.

With the Echo extension disabled, Special:Mute works as before.

No errors seen in the logs.