Maniphest T220183

prevent newlines in term fields
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Apr 5 2019, 9:57 AM

Description

Problem
When in edit mode and entering a newline (return key on the keyboard), the behavior of the edit field is unclear.

Solution

a newline should not insert a line break
a newline will be ignored when entered in a focused edit field
when being copied in an edit field a newline will be replaced with an empty string.

Open question:
How will aliases separated by pipes be copied?
Would it be possible to replace line breaks in aliases by inserting pipes or actually insert line breaks (as aliases will be separated by something similar to a newline anyhow as stated in T218690)?

Details

	Subject	Repo	Branch	Lines +/-
	Term inputs: prevent newlines	wikibase/termbox	master	+47 -11

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T215515 Termbox Editing Mode
Open	None	T215522 Switch from reading into editing mode
Resolved	Lea_WMDE	T216987 Allow editing of fields
Resolved	• Pablo-WMDE	T220183 prevent newlines in term fields

Event Timeline

• Pablo-WMDE created this task.Apr 5 2019, 9:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2019, 9:57 AM

• Pablo-WMDE claimed this task.Apr 5 2019, 10:05 AM

• Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-12 ✓ board.

Currently implemented in https://gerrit.wikimedia.org/r/plugins/gitiles/data-values/value-view/+/master/lib/jquery/jquery.inputautoexpand.js#212
The name (inputautoexpand) suggested that the same code also deals with what T220185 is trying to achieve.

Found https://github.com/vuejs/awesome-vue/blob/master/README.md#masked-input

Change 501590 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] Term inputs: prevent newlines

https://gerrit.wikimedia.org/r/501590

gerritbot added a project: Patch-For-Review.Apr 5 2019, 3:00 PM

• Hanna_Petruschat_WMDE updated the task description. (Show Details)Apr 5 2019, 5:32 PM

WMDE-leszek added a project: Wikidata-Termbox-Iteration-13.Apr 8 2019, 10:37 AM

WMDE-leszek moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-13 board.

• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-13 board.Apr 10 2019, 8:51 AM

@Hanna_Petruschat_WMDE Thank you for the very precise task definition. One question to be sure: the current wikidata termbox does not replace newlines with "a space" but with an empty string. Is this change in behavior intended?

@Pablo-WMDE
Nope. This is my missing ability to define this as needed in tech tongue (I was even googling a "correct" term and apparently didn't come across one)