Page MenuHomePhabricator

Context menu (long press) has extremely light grey text with the dark and black themes
Closed, ResolvedPublic

Description

From OTRS (I don’t have a Samsung S4 Tablet but according to the detail of this report I assume it’s a thing):

  • Bug present in Android App 2.7.276-r-2019-03-27 and Android App 2.7.276-beta-2019-03-27:
  • Context pop-up (long press) menu has extremely light grey text with the dark and black themes. Screenshots of issue, settings, and affected system information attached. My Pixel 2 XL running Android 9 build number PQ2A.190305.002 is not exhibiting this issue with the same app settings.
  • Changing the theme with the "TT" toolbar button to a different theme temporarily fixes the issue until the app is closed and reopened. Thank you.

Screenshots:

Event Timeline

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptApr 5 2019, 4:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Do we know the version of Android that is running on the S4 tablet?

Do we know the version of Android that is running on the S4 tablet?

It is running Android 8.1.

I can reproduce it on the Huawei tablet when entering the article and long pressing on links before doing other actions.

@Charlotte @schoenbaechler The root cause for this bug is that the custom styles are not getting applied to the dialog on the first load. It is the same behavior in light mode too, but we do not notice as our custom colors and default are close. With Dark/Black mode, the default styles for dialogs assigns the textPrimaryColor to the text and hence renders the way we see in the screenshot, very light[which is the primary text color in dark mode].
It is unclear as to why this is happening and why it gets resolved when we try to take any action in the bottom sheet, say, changing the theme or dimming image settings from the bottom sheet.. So I will open an issue on sdk repo and will wait for your responses to move it to tracking.

@ABorbaWMF @Charlotte Testing on Wikipedia app 2.7.280-beta-2019-05-01, using this tablet:


Context pop-up is fixed now on both Black/Dark modes, I had the app on Black already because it was set up for Android
regression last week, so I believe its actually fixed now and not because I had tested the TT tools.