Page MenuHomePhabricator

Focusable nodes don't scroll past toolbar when focused
Closed, ResolvedPublic

Description

We attempt to scroll focsuables into view when focusing, but we don't account for the toolbar, like we do with linear selections.

exepctedresult
image.png (541×433 px, 135 KB)
image.png (503×429 px, 124 KB)

Event Timeline

Change 501663 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] OO.ui.Element: Make scrollIntoView more flexible

https://gerrit.wikimedia.org/r/501663

Change 501678 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Unify selection scroll code

https://gerrit.wikimedia.org/r/501678

Change 501663 merged by jenkins-bot:
[oojs/ui@master] OO.ui.Element: Make scrollIntoView more flexible

https://gerrit.wikimedia.org/r/501663

Change 504473 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.31.4

https://gerrit.wikimedia.org/r/504473

Change 504473 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.4

https://gerrit.wikimedia.org/r/504473

"product owner review" means it's just awaiting final review by the PM before being closed

Change 501678 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Unify selection scroll code

https://gerrit.wikimedia.org/r/501678

Change 510945 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d5a7325ef)

https://gerrit.wikimedia.org/r/510945

Change 510945 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d5a7325ef)

https://gerrit.wikimedia.org/r/510945