Maniphest T220248

OOUI Popup should use `drop-shadow` where applicable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Apr 5 2019, 11:06 PM

Description

Popups currently, as of v0.31.3, rely on box-shadow, which is quite well-supported, but implies a UI glitch, as the shadow is rendered only *drumroll* on boxes.
The callouts are not covered by it.

Proposal

Use [[ https://caniuse.com/#feat=css-filters | filter: drop-shadow ]] where applicable in progressive enhancement manner.

v0.31.3	Proposed
WikimediaUI theme

Apex theme

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.31.4	mediawiki/core	master	+523 -129
	PopupWidget: Progressively enhance to use `filter: drop-shadow()`	oojs/ui	master	+22 -0

Customize query in gerrit

Related Objects

Mentioned In: T221705: [Regression pre-wmf.2] The context menu for categories is appearing transparent
T219585: Popups' relying on `box-shadow` and `border` combination leads to visual glitches
Mentioned Here: T221705: [Regression pre-wmf.2] The context menu for categories is appearing transparent

Event Timeline

Volker_E created this task.Apr 5 2019, 11:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 5 2019, 11:06 PM

JJMC89 added a project: Page-Previews.Apr 5 2019, 11:42 PM

This is about the Popup element in OOUI, it is not about the MediaWiki extension internally called "Popups".

Krinkle renamed this task from Popups should use `drop-shadow` where applicaple to OOUI Popup should use `drop-shadow` where applicaple.Apr 5 2019, 11:44 PM

Jdforrester-WMF renamed this task from OOUI Popup should use `drop-shadow` where applicaple to OOUI Popup should use `drop-shadow` where applicable.Apr 5 2019, 11:45 PM

Change 501988 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] PopupWidget: Progressively enhance to use filter: drop-shadow()

https://gerrit.wikimedia.org/r/501988

gerritbot added a project: Patch-For-Review.Apr 7 2019, 4:09 AM

Volker_E triaged this task as Medium priority.Apr 8 2019, 3:56 AM

Volker_E added a project: CSS.

Volker_E updated the task description. (Show Details)

Volker_E moved this task from Backlog to Reviewing on the OOUI board.

Change 501988 merged by jenkins-bot:
[oojs/ui@master] PopupWidget: Progressively enhance to use filter: drop-shadow()

https://gerrit.wikimedia.org/r/501988

Volker_E closed this task as Resolved.Apr 8 2019, 8:16 PM

Volker_E claimed this task.

Volker_E moved this task from Reviewing to OOUI-0.31.4 on the OOUI board.

Volker_E edited projects, added OOUI (OOUI-0.31.4); removed OOUI.