Page MenuHomePhabricator

ISBN Special:BookSources page - world map doesn't work on mobile site
Closed, ResolvedPublic

Description

Author: malrase

Description:
When you click on an ISBN, you are directed to a page where you select your location from a world map. Clicking a place on the map doesn't seem to work.


Version: unspecified
Severity: normal

Details

Reference
bz20030

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:48 PM
bzimport set Reference to bz20030.
bzimport added a subscriber: Unknown Object (MLST).

That page is a mess too begin with of course, but mostly the problem is: "Any scaling of the image breaks the conversion of areas in the current implementation." http://www.sagehill.net/docbookxsl/Imagemaps.html

Hello I'm not sure I understand this issue and it is approaching 3 years old.. is this still relevant?

We should probably disable image maps so that pages like this [1] do not break when the images they apply to are scaled. Another idea would be for the page editor to wrap the map and instructions in a div with class nomobile to remove it from the mobile site altogether (This requires help from a Wikipedia admin).

I would suggest the use of svg as a better alternative for this sort of thing.

[1] http://en.m.wikipedia.org/wiki/Special:BookSources/9780674027954

I suggest we simply stop resizing of this image via a noresize class so it looks like this:

Whoever has the power could the class noresize be added to
<div class="thumb tleft">

		<div class="thumbinner" style="width:402px;">
			<div class="noresize">
				<map name="ImageMap_1_282378177"></map>
				<img

I've made a change in MobileFrontend which will allow scrolling on these elements and thus retain the size thus the image map will still work
https://gerrit.wikimedia.org/r/7723

Turns out the change needed is in the ImageMap extension
Sent fix:
https://gerrit.wikimedia.org/r/7851

Reviewing this now the map seems to be gone altogether on the mobile version of Special:BookSources so closing as works for me

Map is back, resized, and clicking anywhere does not map to the resized image again.

This is a different bug now as the map does the right thing but doesn't open the section it refers to - bug 41514

  • This bug has been marked as a duplicate of bug 41514 ***

(Note if you look at the address bar when you click on somewhere in the map for me at least it seems to update correctly)