Maniphest T220356

Fix cyclic dependencies in ORES extension
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ladsgroup
	Apr 8 2019, 10:11 AM

Description

This is the graph of the dependencies of the namespaces:

namespace-usage.svg12 KBDownload

And this is the dependencies of the classes:

class-usage.svg193 KBDownload

This is not good.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Move WatchedItemQueryServiceExtension hook handling to its class	mediawiki/extensions/ORES	master	+15 -15
	Move classes around so namespaces don't couple tightly to each other	mediawiki/extensions/ORES	master	+96 -85

Customize query in gerrit

Event Timeline

Ladsgroup created this task.Apr 8 2019, 10:11 AM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptApr 8 2019, 10:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 502267 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/ORES@master] Move classes around so namespaces don't couple tightly to each other

https://gerrit.wikimedia.org/r/502267

gerritbot added a project: Patch-For-Review.Apr 8 2019, 4:19 PM

namespace-usage-new.svg14 KBDownload

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Apr 8 2019, 5:44 PM

I need to do the cyclic dependencies between classes.

Change 502267 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Move classes around so namespaces don't couple tightly to each other

https://gerrit.wikimedia.org/r/502267

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 8 2019, 7:01 PM

Change 502776 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/ORES@master] Move WatchedItemQueryServiceExtension hook handling to its class

https://gerrit.wikimedia.org/r/502776

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Apr 10 2019, 1:20 PM

Ladsgroup moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Apr 15 2019, 8:33 PM

Ladsgroup closed this task as Resolved.Apr 17 2019, 6:26 PM

Change 502776 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Move WatchedItemQueryServiceExtension hook handling to its class

https://gerrit.wikimedia.org/r/502776

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 19 2019, 9:01 PM

Fix cyclic dependencies in ORES extensionClosed, ResolvedPublicActions

Description

Details

Event Timeline

Fix cyclic dependencies in ORES extension
Closed, ResolvedPublic
Actions