Page MenuHomePhabricator

[Bug] First click of save doesn't save changes
Closed, ResolvedPublic

Description

In my local dev setup:
Running commit: c148ff2e39e00c1add62315cccadee8207f9a6ec
Running with docker-compose up for the service

If I:

  • Load and item page
  • Wait for the page to fully load
  • Click the edit pen
  • Make some text edit to the primary description
  • Click save

Then:

  • I am returned to read mode without the edit being made
  • In the network tab the edit is not reflected in the wbeditentity request

If I then:

  • click edit again
  • make a change
  • click save

Then:

  • the change is reflected
  • and the request is correctly made

Peek 2019-04-08 12-18.gif (360×1 px, 130 KB)

Event Timeline

In attempting to debug this I built the development version with docker-compose run -e NODE_ENV=development --rm node ./node_modules/.bin/vue-cli-service build

I then manually copied dist/wikibase.termbox.main.js to the appropriate place (mediawiki/extensions/Wikibase/view/lib/wikibase-termbox/dist/)

This then hit: T220375

Tarrow moved this task from Doing to To Do on the Wikidata-Termbox-Iteration-13 board.

Moving back to To Do because it looks like debugging is probably going to need some thought about: T220375 first to be effective. Also want to merge the results of T220379 just in case there is some connection.

Tarrow claimed this task.

This appears to be solved by the fix for https://phabricator.wikimedia.org/T220379#5097045 :)