Maniphest T220375

Vue warn: client-side rendered virtual DOM not matching server-rendered content
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Apr 8 2019, 12:09 PM

Description

Happened when loading a dist/ folder build for development (2MB) in integration with wikibase - danger of heisenbug.

Do we have unbalanced mark-up?

Potentially a good moment to introduce https://eslint.vuejs.org/rules/

Bildschirmfoto von 2019-04-08 14-05-27.png (1×1 px, 177 KB)

Repro per @Tarrow https://phabricator.wikimedia.org/T220364

Details

	Subject	Repo	Branch	Lines +/-
	eslint: introduce vue rules	wikibase/termbox	master	+124 -64

Customize query in gerrit

Related Objects

Mentioned In: T220364: [Bug] First click of save doesn't save changes

Event Timeline

• Pablo-WMDE created this task.Apr 8 2019, 12:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2019, 12:09 PM

Tarrow mentioned this in T220364: [Bug] First click of save doesn't save changes.Apr 9 2019, 11:33 AM

• Pablo-WMDE updated the task description. (Show Details)Apr 10 2019, 9:59 AM

• Matthias_Geisler_WMDE claimed this task.Apr 11 2019, 7:12 AM

• Matthias_Geisler_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-13 board.

• Pablo-WMDE updated the task description. (Show Details)Apr 11 2019, 10:39 AM

• Pablo-WMDE claimed this task.Apr 11 2019, 10:46 AM

Change 503285 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] eslint: introduce vue rules

https://gerrit.wikimedia.org/r/503285

gerritbot added a project: Patch-For-Review.Apr 12 2019, 10:20 AM

The answer is: it's by design and not a problem. Using a v-show instead would avoid it but also cause significantly more mark-up sent through SSR without any added benefit and potentially causing other problems (we tried that before and TermTextField struggeled to resizeTextField() on initially hidden textareas, i.e. when first opened the textareas were all tiny).

• Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-13 board.Apr 12 2019, 11:24 AM

@Jakob_WMDE you mentioned that you (quickly?) looked into this. If what I wrote makes sense then please feel free to move this task to done as there is no patch strictly connected to it - https://gerrit.wikimedia.org/r/503285 was created as bycatch but it is by no means representative of what the title of this ticket is about.

Yes, makes sense to me!

Change 503285 merged by jenkins-bot:
[wikibase/termbox@master] eslint: introduce vue rules