| • Pablo-WMDE | |
| Apr 8 2019, 12:36 PM |
| F28595057: Bildschirmfoto von 2019-04-08 14-30-49.png | |
| Apr 8 2019, 12:36 PM |
GIVEN I am on an Entity page AND the entity exists and is editable AND the entity does not have any information in the primary language WHEN I set the label in the primary language (es) THEN an error is thrown "TypeError: "can't define property "es": Array is not extensible""
Presumably due to
https://vuex.vuejs.org/guide/mutations.html#mutations-follow-vue-s-reactivity-rules
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T215515 Termbox Editing Mode | |||
| Open | None | T215522 Switch from reading into editing mode | |||
| Resolved | Lea_WMDE | T216987 Allow editing of fields | |||
| Resolved | BUG REPORT | • Matthias_Geisler_WMDE | T220379 Commiting changes in languages not yet part of the store |
Change 502446 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] BugFix for Array is not extensible
@Pablo-WMDE @Jakob_WMDE I heard on IRC that you found performance problems with using spread and replace on the entity mutations. Is that the case? If so I guess we need to use Vue.set but otherwise I think we might want to use spread for consistency, readability lack of dark-arts etc..
@Matthias_Geisler_WMDE said: "if you need more than one line you are doing it wrong", i.e. either 1 Vue.set() to add an individual property or 1 use of the spread operator to add a bunch of them.
Change 502826 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Replace empty arrays with empty objects in EntityInitializer
Change 502446 merged by jenkins-bot:
[wikibase/termbox@master] Bug Fix for Array is not extensible when adding keys to state objects
Change 502826 merged by jenkins-bot:
[wikibase/termbox@master] Replace empty arrays with empty objects in EntityInitializer