Maniphest T220393

AliasesEdit: styling
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Apr 8 2019, 2:17 PM

Description

make it look like the mocks!
don't forget the blue border of the surrounding aliases component when any of the alias input fields are focused

Details

Subject	Repo	Branch	Lines +/-
AliasesEdit: Style it	wikibase/termbox	master	+97 -25
_termInput mixins: refactored to name by function	wikibase/termbox	master	+47 -50
Divide termInput in multible parts	wikibase/termbox	master	+28 -25

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jakob_WMDE	T218690 Show each alias in a separate line in edit mode
		Resolved		• Matthias_Geisler_WMDE	T220393 AliasesEdit: styling

Event Timeline

Jakob_WMDE created this task.Apr 8 2019, 2:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2019, 2:17 PM

TIL https://caniuse.com/#feat=css-focus-within (at only 80% unfortunately)

• Matthias_Geisler_WMDE claimed this task.Apr 12 2019, 9:45 AM

• Matthias_Geisler_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-13 board.

Change 503330 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Style Aliases Edit

https://gerrit.wikimedia.org/r/503330

gerritbot added a project: Patch-For-Review.Apr 12 2019, 12:10 PM

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-13 board.Apr 12 2019, 12:15 PM

Change 503922 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[wikibase/termbox@master] Break border-style out of termInput

https://gerrit.wikimedia.org/r/503922

• Matthias_Geisler_WMDE moved this task from Peer Review to Doing on the Wikidata-Termbox-Iteration-13 board.Apr 17 2019, 11:58 AM

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-13 board.Apr 17 2019, 12:53 PM

Change 504921 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[wikibase/termbox@master] _termInput mixins: refactored to name by function

https://gerrit.wikimedia.org/r/504921

Jakob_WMDE added a project: Wikidata-Termbox-Iteration-14.Apr 23 2019, 12:18 PM

Jakob_WMDE moved this task from To Do to Peer Review on the Wikidata-Termbox-Iteration-14 board.

Change 503922 abandoned by Pablo Grass (WMDE):
Divide termInput in multible parts

Reason:
Merged into I091009e1f0bc0ec2dc420406dbefbccddc644ccb

https://gerrit.wikimedia.org/r/503922

Change 504921 abandoned by Pablo Grass (WMDE):
_termInput mixins: refactored to name by function

Reason:
Merged into I091009e1f0bc0ec2dc420406dbefbccddc644ccb

https://gerrit.wikimedia.org/r/504921

Change 503330 merged by jenkins-bot:
[wikibase/termbox@master] AliasesEdit: Style it

https://gerrit.wikimedia.org/r/503330

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Termbox-Iteration-14 board.Apr 23 2019, 4:59 PM