Page MenuHomePhabricator
Create Task
Maniphest T220444

Change "remove statements" text to "remove all" on statement panels
Closed, ResolvedPublic
Actions

Description

User story: N/A

We have this:

In edit mode, at the bottom of each panel is a "remove statements" button that clears out all the values in that panel.

We want this:

To avoid confusion/add clarity (not everyone knows what a statement is), just call it "remove all"

Screenshots (if possible):

Acceptance Criteria:

  • The link text is "Remove all"

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Change 'remove statement' to 'remove all'mediawiki/extensions/WikibaseMediaInfomaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

• Ramsey-WMF created this task.Apr 8 2019, 8:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2019, 8:14 PM
• Ramsey-WMF triaged this task as Medium priority.Apr 8 2019, 8:14 PM
• Ramsey-WMF changed the subtype of this task from "Bug Report" to "Task".
• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Team-Current-Work.
• Ha78na claimed this task.Apr 8 2019, 8:27 PM
gerritbot added a comment.Apr 8 2019, 8:46 PM

Change 502335 had a related patch set uploaded (by Ha78na; owner: Ha78na):
[mediawiki/extensions/WikibaseMediaInfo@master] Change 'remove statement' to 'remove all'

https://gerrit.wikimedia.org/r/502335

gerritbot added a project: Patch-For-Review.Apr 8 2019, 8:46 PM
• Ha78na mentioned this in rEWBI2a766a58acf5: Change 'remove statement' to 'remove all'.Apr 8 2019, 8:53 PM
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Apr 8 2019, 8:57 PM
• Ramsey-WMF moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.
• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.
Jdforrester-WMF moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Apr 8 2019, 9:09 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Apr 8 2019, 9:42 PM

Change 502335 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Change 'remove statement' to 'remove all'

https://gerrit.wikimedia.org/r/502335

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 8 2019, 10:00 PM
• Ha78na reassigned this task from • Ha78na to • Ramsey-WMF.Apr 9 2019, 12:48 PM
• Ha78na edited subscribers, added: • Ha78na; removed: Aklapper.
• Ramsey-WMF reassigned this task from • Ramsey-WMF to • PDrouin-WMF.Apr 10 2019, 4:59 PM
• Ramsey-WMF added a subscriber: • PDrouin-WMF.

Looks good on Beta (not on test commons yet). What say you, @PDrouin-WMF ?

• PDrouin-WMF added a comment.Apr 10 2019, 5:17 PM

@Ramsey-WMF looks good on Beta for me too!

• Ramsey-WMF claimed this task.Apr 10 2019, 5:35 PM
• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.
• Ramsey-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.
Cparle subscribed.Apr 18 2019, 1:10 PM

ok on test-commons

• Ramsey-WMF closed this task as Resolved.Apr 23 2019, 11:27 PM

verified on prod

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits