Page MenuHomePhabricator

2ColConf: Reset Edit warning should be clear on what it resets – just line edit or the whole text
Closed, ResolvedPublic1 Estimated Story Points

Description

User Story:: As a user, I want to get rid of edits I do not like, so I can start anew or avoid problems

Context of use: The user would use the 2nd version of the 2ColConflict (the line-based-merge) and has edited one of the "select version" text fragments but wants to reset the edit.

Current Problems: Currently, the warning for the reset says:

Discard changes? Your text will be reset to what it was when the edit conflict occurred.

image.png (207×336 px, 14 KB)

However, it is unclear what "text" is concerned: Just the line edit (I think this it is) or the whole text? The latter is frightening.

Possible Solution: One way to improve the situation for the user is

(Emphasis for highlighting the change, not for formatting of the message)

Discard changes? Your text of this conflicting line will be reset to what it was when the edit conflict occurred

Also, we should be clear to what the text is reset to: "their" or "my" version? This depends on the side of the conflict you reset (which switches the name in [user] to the user name of the other party or to your name)

Discard changes? The text of [user]’s version of this conflicting line will be reset to its state when the conflict occurred

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Suggested new text:

Discard changes? The text in this box will be reset to what it was when the edit conflict occurred.

Change 556653 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Improve reset button's warning message

https://gerrit.wikimedia.org/r/556653

Change 556653 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Improve reset button's warning message

https://gerrit.wikimedia.org/r/556653

JStrodt_WMDE claimed this task.
JStrodt_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-12-11 board.