Page MenuHomePhabricator
Create Task
Maniphest T220489

Use `data-mw="interface"` instead of `mw-data="interface"`
Closed, ResolvedPublic
Actions

Description

https://www.mediawiki.org/wiki/Help:Extension:Kartographer contains:

<a class="mw-kartographer-map" mw-data="interface" data-style="osm-intl" data-width="250" data-heigh…13,-122.3988,250x250.png?lang=en); height: 250px;" href="/wiki/Special:Map/13/37.8013/-122.3988/en">

https://validator.w3.org/nu/?doc=https://www.mediawiki.org/wiki/Help:Extension:Kartographer reports:

Attribute mw-data not allowed on element a at this point.

The intended HTML attribute is data-mw="interface" instead of mw-data="interface".

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove check for `mw-data="interface"`mediawiki/extensions/Kartographermaster+25 -56
Add [data-mw="interface"] to the kartographer selectormediawiki/extensions/Wikibasemaster+1 -1
Support data-mw="interface" also in staticframemediawiki/extensions/Kartographermaster+4 -1
Use `data-mw="interface"` instead of `mw-data="interface"`mediawiki/extensions/Kartographermaster+52 -46
Customize query in gerrit

Related Objects

Event Timeline

Fomafix created this task.Apr 9 2019, 10:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2019, 10:46 AM
gerritbot added a comment.Apr 9 2019, 1:21 PM

Change 502485 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/Kartographer@master] Use data-mw="interface" instead of mw-data="interface"

https://gerrit.wikimedia.org/r/502485

gerritbot added a project: Patch-For-Review.Apr 9 2019, 1:21 PM

Change 502486 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/Kartographer@master] Remove check for mw-data="interface"

https://gerrit.wikimedia.org/r/502486

gerritbot added a comment.Apr 10 2019, 5:29 AM

Change 502485 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Use data-mw="interface" instead of mw-data="interface"

https://gerrit.wikimedia.org/r/502485

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Apr 10 2019, 6:01 AM
gerritbot added a comment.Apr 14 2019, 3:47 PM

Change 503760 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/Wikibase@master] Add [data-mw="interface"] to the kartographer selector

https://gerrit.wikimedia.org/r/503760

MSantos moved this task from Unsorted to Tracking on the Maps (Kartographer) board.Apr 16 2019, 3:07 PM
Pikne mentioned this in T221439: Static mapframe not clickable in 1.34.0-wmf.1 .Apr 19 2019, 8:16 AM
gerritbot added a comment.Apr 19 2019, 9:19 AM

Change 505217 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/Kartographer@master] Support data-mw="interface" also in staticframe

https://gerrit.wikimedia.org/r/505217

gerritbot added a comment.Apr 22 2019, 3:37 PM

Change 505217 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Support data-mw="interface" also in staticframe

https://gerrit.wikimedia.org/r/505217

gerritbot added a comment.Jun 11 2019, 5:30 PM

Change 503760 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add [data-mw="interface"] to the kartographer selector

https://gerrit.wikimedia.org/r/503760

gerritbot added a comment.Jun 11 2019, 5:30 PM

Change 502486 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Remove check for mw-data="interface"

https://gerrit.wikimedia.org/r/502486

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2019, 6:10 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.10; 2019-06-18); removed MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Jun 11 2019, 8:00 PM
Fomafix closed this task as Resolved.Jun 11 2019, 8:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits