Change 521521 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Don't generate HTML for segments when copying

https://gerrit.wikimedia.org/r/521521

The content can be cleaned up when copying and the converter has separate modes when generating HTML for Parsoid/Clipboard.

Internal copy/paste and drag/drop don't use clipboard HTML so won't be affected.

Change 521521 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Don't generate HTML for segments when copying

https://gerrit.wikimedia.org/r/521521

@Esanders @santhosh can you give me an example of where those tags are used so I can see if they're still being passed correctly?

@Jpita Every paragraph in a Content translation target document has them (they are what make the sentences appear yellow when you hover on them). So just copy anything out of a CX translation, and paste it into a normal VE instance to test this.

@Esanders thanks!

In T220495#5395580, @santhosh wrote:

@Esanders If your fix can be done only for the target language, it would be good. But since ve.dm.CXSentenceSegmentAnnotation.static.toDomElements has no informaiton on the language, that is not easy. What do you suggest?

If we just did it based on the document language you could still write segments to the clipboard by copying from the source document.

Thinking about what the converter modes mean, I think clipboard mode might still be the correct mode to use, as essentially it means "for export to another VE instance, via some serialised storage".

I think what we should do is pass an additional flag to the converter saying isForTranslation, and then check for this in ve.dm.CXSentenceSegmentAnnotation.static.toDomElements

Strictly speaking we should extend the converter and create a new mode to do this, but we can just hack it for now:

ve.dm.converter.isForTranslation = true;
html = ve.dm.converter.getDomFromNode( ... );
ve.dm.converter.isForTranslation = false;

Change 528471 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Re-apply "Don't generate HTML for segments when copying"

https://gerrit.wikimedia.org/r/528471

Thanks. That works

Change 528471 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Re-apply "Don't generate HTML for segments when copying"

https://gerrit.wikimedia.org/r/528471

I'd recommend adding some unit tests that assert that segments are preserved when translating.