Page MenuHomePhabricator

Allow viewing of qualifiers with unsupported data types
Closed, ResolvedPublic

Description

We have this

The file page displays all qualifiers that have been associated with the statements, regardless of their data types.

We want this

All qualifiers, even with unsupported data types, must be displayed, in a way that makes sense, so that we can spot vandalism.

Acceptance Criteria

Test case set up at https://commons.wikimedia.beta.wmflabs.org/wiki/File:T220616.png

  • qualifier with unsupported data type is shown
  • qualifier with unsupported data type doesn't cause other elements on the page (other, valid qualifiers or statements) to break
  • qualifier with unsupported data type is displayed in a acceptable fashion (no obvious errors)

Event Timeline

Change 502491 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Gracefully handle unsupported qualifiers

https://gerrit.wikimedia.org/r/502491

Change 502491 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Gracefully handle unsupported qualifiers

https://gerrit.wikimedia.org/r/502491

Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF subscribed.

Renders, no obvious error, doesn't break other things:

image.png (338×816 px, 39 KB)

Shown as uneditable:

image.png (412×815 px, 47 KB)