Various templates in MobileFrontend are shipped via ResourceLoader. We will load them inline via webpack. We will do this for all remaining template files.
These are:
212: "Panel.hogan": "resources/mobile.init/Panel.hogan" 235: "mediawiki.template.hogan", 412: "SectionAddOverlay/contentHeader.hogan": "resources/mobile.talk.overlays/talkSectionAddContentHeader.hogan", 413: "SectionAddOverlay.hogan": "resources/mobile.talk.overlays/talkSectionAdd.hogan", 414: "Section/header.hogan": "resources/mobile.talk.overlays/talkSectionHeader.hogan", 415: "Section/content.hogan": "resources/mobile.talk.overlays/talkSectionContent.hogan" 456: "LoadErrorMessage.hogan": "resources/mobile.mediaViewer/LoadErrorMessage.hogan", 457: "ImageCarousel.hogan": "resources/mobile.mediaViewer/ImageCarousel.hogan" 486: "CategoryTabs.hogan": "resources/mobile.categories.overlays/CategoryTabs.hogan", 487: "CategoryTab.hogan": "resources/mobile.categories.overlays/CategoryTab.hogan", 488: "CategoryAddOverlay.hogan": "resources/mobile.categories.overlays/CategoryAddOverlay.hogan", 489: "CategoryAddOverlayHeader.hogan": "resources/mobile.categories.overlays/CategoryAddOverlayHeader.hogan" 522: "LanguageSearcher.hogan": "resources/mobile.languages.structured/LanguageSearcher.hogan" 658: "Nearby.hogan": "resources/mobile.special.nearby.scripts/nearby.hogan" 677: "PhotoItem.hogan": "resources/mobile.special.uploads.scripts/PhotoItem.hogan", 678: "PhotoList.hogan": "resources/mobile.special.uploads.scripts/PhotoList.hogan"
Acceptance criteria
- All the files in the editor have been inlined.
- Increase in JS bundlesizes should be consistent with the removal of the size of ResourceLoader's mobile.startup module. Change in bytes shipped to client should be recorded.
- There are no hogan files in the resources folder
QA steps
Image Overlay
- Go to http://readers-web-master.wmflabs.org/wiki/Barack_Obama?mobileaction=toggle_view_mobile#/media/File%3APresident_Barack_Obama.jpg
- Test the image viewer feature making sure you can view an image and navigate between images using the left and right arrows
Talk Overlay
- Login to https://en.m.wikipedia.beta.wmflabs.org and go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain#/talk
- Test the talk overlay feature making sure you can access it, view topics and create a new topic
Language Overlay
- Go to https://readers-web-master.wmflabs.org/wiki/Barack_Obama?mobileaction=toggle_view_mobile#/languages
- Test the language feature making sure you can search/filter languages
Table of Contents
- Go to http://readers-web-master.wmflabs.org/wiki/Barack_Obama?mobileaction=toggle_view_mobile
- Find and test the table of contents feature in tablet ensuring it renders with the correct sub headings
Category Overly
- Login to https://en.m.wikipedia.beta.wmflabs.org, turn on Beta mode, and go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain#/categories
- Test the category overlay feature making sure you can access it, view categories and create a new category
Nearby
- Go to https://readers-web-master.wmflabs.org/wiki/Special:Nearby?mobileaction=toggle_view_mobile and click the "Show nearby articles button"
- Test the Special:Nearby feature making sure you can access it, view pages nearby
Special:Uploads
- Login to https://readers-web-staging.wmflabs.org and Upload an image at https://readers-web-staging.wmflabs.org/wiki/Special:Upload?mobileaction=toggle_view_mobile
- Go to https://readers-web-staging.wmflabs.org/wiki/Special:Uploads?mobileaction=toggle_view_mobile and make sure you can access it, view uploads
Sign off steps
- Make sure a task has been written to make mediawiki.template.hogan a redirect to the mediawiki.template.mustache file
QA Results
| AC | Status | Details |
| 1 | ✅ | T220619#5138312 |
| 2 | ✅ | T220619#5138312 |
| 3 | ✅ | T220619#5138312 |
| 4 | ✅ | T220619#5138312 |
| 5 | ✅ | T220619#5138312 |
| 6 | ✅ | T220619#5138312 |
| 7 | ✅ | T220619#5147037 |
