However do allow the user to tap to reactivate if within previous selection
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | matmarex | T221328 [Epic] Mobile VE usability improvements (FY18-19 Q4) | |||
| Open | None | T209505 EPIC: Fix selection issues on mobile | |||
| Resolved | Esanders | T220633 Selection experiment: Don't re-activate selection after toolbar/dialog/inspector open on mobile |
Event Timeline
Comment Actions
Change 502895 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Re-use previousSelection when re-activating
Comment Actions
Change 502896 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Don't reactivate after opening tools/windows on mobile
Comment Actions
Change 502895 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Re-use previousSelection when re-activating
Comment Actions
Change 504790 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6afc66096)
Comment Actions
Change 504790 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6afc66096)
Comment Actions
Change 502896 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Don't reactivate after opening tools/windows on mobile
Comment Actions
Change 506223 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d0ff41a71)
Comment Actions
Change 506224 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b049d6049)
Comment Actions
Change 506223 abandoned by Jforrester:
Update VE core submodule to master (d0ff41a71)
Comment Actions
Change 506224 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b049d6049)
Comment Actions
This doesn't seem to consistently work for the link inspector (…anymore?), because it changes the selection from collapsed to expanded when closing.
To reproduce the problem:
- Place a collapsed selection inside a link annotation
- Open link inspector
- Click "Done" to close link inspector
Expected: deactivated expanded selection covering the link. Actual: it is activated.
It also works correctly if you start from an expanded selection covering the link, or use the "Back" button to close the inspector.
Comment Actions
Change 516581 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] WindowAction: Refactor surface re-activation logic once again
Comment Actions
Can you check the behaviour on the prototype server as I think it might be working there with the new context changes?
Comment Actions
Change 516581 abandoned by Bartosz Dziewoński:
WindowAction: Refactor surface re-activation logic once again
Reason:
Looks like the bug is also fixed by the changes in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/ /510229/16/src/ui/inspectors/ve.ui.AnnotationInspector.js , so maybe this isn't needed.
Comment Actions
Eh, @gerritbot… https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/510229/16/src/ui/inspectors/ve.ui.AnnotationInspector.js
Well I guess this is also blocked on the edit cards work, then.
Comment Actions
Actually I will split this change into a separate commit. It is not really related to the other context changes, and it seems to be the only functional change in that commit that affects both old and new contexts.
Comment Actions
Change 517133 had a related patch set uploaded (by Bartosz Dziewoński; owner: Esanders):
[VisualEditor/VisualEditor@master] ve.ui.AnnotationInspector: Deactivate surface after closing on mobile
Comment Actions
Change 517133 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.AnnotationInspector: Deactivate surface after closing on mobile
Comment Actions
Change 517137 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (44556e8fd)
Comment Actions
Change 517137 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (44556e8fd)
Comment Actions
@matmarex: I am a bit confused here, what's collapsed selection and expanded selection?
Comment Actions
Collapsed selection is just a text cursor, while expanded selection is a "normal" selection.
We call both of these things "selections" because internally, they are represented by the same structure, except that for collapsed selections (text cursors) the beginning and end positions are the same.
| Collapsed selection | Expanded selection |
 |  |
Comment Actions
Collapsed selection is just a text cursor, while expanded selection is a "normal" selection.
We call both of these things "selections" because internally, they are represented by the same structure, except that for collapsed selections (text cursors) the beginning and end positions are the same.
Collapsed selection Expanded selection
Thanks for explaining @matmarex. I think it's working as expected now. Just to confirm the highlight in the screenshot below is called " deactivated expanded selection" right?
Comment Actions
The blue highlight with border is yet another thing, it indicates that text you type will go inside of the link, rather than outside. Without it, when you place the cursor at the beginning or end of a link, there would be no way to tell if the typed text will be linked or not. We just call it the active annotation highlight (it was also occasionally called a "cartouche" but I think we stopped using that term).
| Active link annotation is highlighted, typed text will become part of the link after "Trafalgar" |  |
| No active annotation, typed text will be plain text after the link, before the comma |  |
Note that we used to have an issue where the active annotation would still be highlighted after closing the keyboard, which is pointless (you can't type anyway, so it indicates nothing). I fixed it recently in https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/518817 (your comment makes me think you also noticed that bug :) ).
Deactivated selections use a gray background (expanded) or a black cursor (collapsed), and indicate that you can use the toolbar tools (e.g. tapping the link tool with create a link over the selected text), but can't type (this is also evident from the lack of keyboard on mobile).
| Collapsed selection (deactivated) | Expanded selection (deactivated) |
 |  |