Page MenuHomePhabricator
Create Task
Maniphest T220656

Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.34 release
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

T205029: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.33 release || T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release

This is a list of potential deprecated code to drop. Not all of it will be dropped before 1.34 (and we'll move entries to a parallel ticket for 1.35). Found by manually looking for hard deprecations; soft-deprecated code isn't listed here (yet?).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Docs: Remove reference to `UploadVerification` hook, removed in 1.34mediawiki/coremaster+1 -2
Drop APIEditBeforeSave hookmediawiki/coremaster+2 -79
Skin::outputPage: Drop support for specifying a context, deprecated in 1.20mediawiki/coremaster+4 -19
Remove support for calling OutputPage::wrapWikiMsg() with an options parametermediawiki/coremaster+2 -7
GlobalFunctions: Remove deprecated wfCountDown() function from coremediawiki/coremaster+2 -24
libs: Remove unused deprecated BufferingStatsdDataFactory::getBuffer()mediawiki/coremaster+1 -9
Drop SpecialPage::getTitle()mediawiki/coremaster+2 -12
HTMLForm: Remove deprecated unused getErrors() methodmediawiki/coremaster+3 -15
WikiPage: Make prepareContentForEdit method not accept an integermediawiki/coremaster+9 -15
SearchEngine: Remove deprecated unused method `transformSearchTerm()`mediawiki/coremaster+1 -14
jobqueue: Remove deprecated unused method pushLazyJobs()mediawiki/coremaster+1 -15
changetags: Remove deprecated unused method `purgeTagUsageCache()`mediawiki/coremaster+1 -9
api: Remove deprecated `prepareUrlQuerySearchString()` from coremediawiki/coremaster+2 -29
Stop Linker::link() handling $query when it's a stringmediawiki/coremaster+2 -6
user: Remove deprecated and unused method `getPasswordValidity()`mediawiki/coremaster+1 -35
Remove deprecated unused method `getModuleScripts()`mediawiki/coremaster+2 -14
Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput()mediawiki/coremaster+2 -28
EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()`mediawiki/coremaster+3 -28
Remove several methods, deprecated in 1.32mediawiki/coremaster+14 -164
Block: Type hint Block constructor, follow-up on I37ab858494a173c6982bbmediawiki/coremaster+3 -4
User: Remove/Kill usage of deprecated User::makeGroupLinkWiki()mediawiki/coremaster+2 -25
User: Remove deprecated methods ::getGroupPage() & ::makeGroupLinkHTML()mediawiki/coremaster+2 -37
classes: Replace usage of deprecated SearchEngine::searchableNamespace()mediawiki/extensions/LiquidThreadsmaster+3 -1
search: Remove unused deprecated methods replaced by MW Servicesmediawiki/coremaster+4 -87
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
xSavitar updated the task description. (Show Details)Apr 29 2019, 9:08 PM
xSavitar updated the task description. (Show Details)Apr 29 2019, 10:10 PM
xSavitar subscribed.

@Jdforrester-WMF, per https://codesearch.wmflabs.org/search/?q=new%20Block%5C(&i=nope&files=&repos=, I think that is no longer the case? I see only hexmode / mediawiki-UserSnoop repo still doing that.

Jdforrester-WMF added a comment.Apr 29 2019, 10:16 PM
In T220656#5145295, @D3r1ck01 wrote:

@Jdforrester-WMF, per https://codesearch.wmflabs.org/search/?q=new%20Block%5C(&i=nope&files=&repos=, I think that is no longer the case? I see only hexmode / mediawiki-UserSnoop repo still doing that.

Yeah, looks like that's unused now. We should remove the support for it in Block.

gerritbot added a comment.Apr 29 2019, 10:38 PM

Change 507215 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] Block: Drop support for individual args in constructing a Block object

https://gerrit.wikimedia.org/r/507215

gerritbot added a comment.Apr 29 2019, 11:16 PM

Change 507221 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput()

https://gerrit.wikimedia.org/r/507221

xSavitar updated the task description. (Show Details)Apr 29 2019, 11:21 PM
xSavitar updated the task description. (Show Details)
gerritbot added a comment.Apr 30 2019, 7:04 PM

Change 507215 merged by jenkins-bot:
[mediawiki/core@master] Block: Type hint Block constructor, follow-up on I37ab858494a173c6982bb

https://gerrit.wikimedia.org/r/507215

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.4; 2019-05-07); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 30 2019, 8:00 PM
xSavitar updated the task description. (Show Details)May 1 2019, 11:46 AM
xSavitar updated the task description. (Show Details)May 1 2019, 11:52 AM
xSavitar updated the task description. (Show Details)May 1 2019, 11:54 AM
xSavitar updated the task description. (Show Details)May 1 2019, 1:12 PM
gerritbot added a comment.May 8 2019, 7:39 PM

Change 508901 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] EditPage: Remove ::safeUnicodeInput() and ::safeUnicodeOutput()

https://gerrit.wikimedia.org/r/508901

gerritbot added a comment.May 9 2019, 4:30 PM

Change 509105 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] Remove several deprecated (in 1.32) no longer used methods from core

https://gerrit.wikimedia.org/r/509105

gerritbot added a comment.May 9 2019, 7:07 PM

Change 509105 merged by jenkins-bot:
[mediawiki/core@master] Remove several methods, deprecated in 1.32

https://gerrit.wikimedia.org/r/509105

gerritbot added a comment.May 9 2019, 7:22 PM

Change 508901 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Remove ::safeUnicodeInput() and ::safeUnicodeOutput()

https://gerrit.wikimedia.org/r/508901

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.5; 2019-05-14); removed MW-1.34-notes (1.34.0-wmf.4; 2019-05-07).May 9 2019, 8:00 PM
gerritbot added a comment.May 9 2019, 8:47 PM

Change 507221 merged by jenkins-bot:
[mediawiki/core@master] Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput()

https://gerrit.wikimedia.org/r/507221

gerritbot added a comment.May 9 2019, 10:28 PM

Change 509159 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] Remove deprecated unused method getModuleScripts()

https://gerrit.wikimedia.org/r/509159

gerritbot added a comment.May 9 2019, 10:34 PM

Change 509160 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] User: Remove deprecated and unused getPasswordValidity()

https://gerrit.wikimedia.org/r/509160

Jdforrester-WMF removed a project: Patch-For-Review.May 10 2019, 4:43 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.May 10 2019, 5:00 PM

Change 509159 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated unused method getModuleScripts()

https://gerrit.wikimedia.org/r/509159

gerritbot added a comment.May 10 2019, 5:00 PM

Change 509160 merged by jenkins-bot:
[mediawiki/core@master] user: Remove deprecated and unused method getPasswordValidity()

https://gerrit.wikimedia.org/r/509160

gerritbot added a comment.May 11 2019, 2:58 PM

Change 509586 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] api: Remove deprecated prepareUrlQuerySearchString() from core

https://gerrit.wikimedia.org/r/509586

gerritbot added a project: Patch-For-Review.May 11 2019, 2:58 PM
gerritbot added a comment.May 11 2019, 3:03 PM

Change 509587 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] changetags: Remove deprecated unused method purgeTagUsageCache()

https://gerrit.wikimedia.org/r/509587

gerritbot added a comment.May 11 2019, 3:07 PM

Change 509588 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] jobqueue: Remove deprecated unused method pushLazyJobs()

https://gerrit.wikimedia.org/r/509588

gerritbot added a comment.May 11 2019, 3:23 PM

Change 509589 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] SearchEngine: Remove deprecated unused method transformSearchTerm()

https://gerrit.wikimedia.org/r/509589

gerritbot added a comment.May 11 2019, 3:29 PM

Change 509590 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Stop Linker::link() handling $query when it's a string

https://gerrit.wikimedia.org/r/509590

gerritbot added a comment.May 11 2019, 3:29 PM

Change 509591 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Remove support for calling OutputPage::wrapWikiMsg() with an options parameter

https://gerrit.wikimedia.org/r/509591

Reedy updated the task description. (Show Details)May 11 2019, 3:33 PM
Reedy updated the task description. (Show Details)
xSavitar updated the task description. (Show Details)May 11 2019, 3:54 PM
gerritbot added a comment.May 11 2019, 6:53 PM

Change 509590 abandoned by Reedy:
Stop Linker::link() handling $query when it's a string

Reason:
T223010 filed to clean up the many usages of the function. Might aswell abandon this instead

https://gerrit.wikimedia.org/r/509590

Reedy updated the task description. (Show Details)May 11 2019, 6:54 PM
gerritbot added a comment.May 11 2019, 7:19 PM

Change 509586 merged by jenkins-bot:
[mediawiki/core@master] api: Remove deprecated prepareUrlQuerySearchString() from core

https://gerrit.wikimedia.org/r/509586

gerritbot added a comment.May 11 2019, 7:19 PM

Change 509587 merged by jenkins-bot:
[mediawiki/core@master] changetags: Remove deprecated unused method purgeTagUsageCache()

https://gerrit.wikimedia.org/r/509587

gerritbot added a comment.May 13 2019, 10:51 AM

Change 509588 merged by jenkins-bot:
[mediawiki/core@master] jobqueue: Remove deprecated unused method pushLazyJobs()

https://gerrit.wikimedia.org/r/509588

gerritbot added a comment.May 13 2019, 3:46 PM

Change 509589 merged by jenkins-bot:
[mediawiki/core@master] SearchEngine: Remove deprecated unused method transformSearchTerm()

https://gerrit.wikimedia.org/r/509589

gerritbot added a comment.May 21 2019, 6:19 PM

Change 511761 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/core@master] WikiPage: Make prepareContentForEdit method not accept an integer

https://gerrit.wikimedia.org/r/511761

matej_suchanek updated the task description. (Show Details)May 21 2019, 6:34 PM
gerritbot added a comment.May 22 2019, 9:24 AM

Change 511761 merged by jenkins-bot:
[mediawiki/core@master] WikiPage: Make prepareContentForEdit method not accept an integer

https://gerrit.wikimedia.org/r/511761

Krinkle subscribed.May 22 2019, 8:58 PM
In T220656#5172998, @gerritbot wrote:

[mediawiki/core@master] Remove deprecated unused method getModuleScripts()
https://gerrit.wikimedia.org/r/509159

Also closes T188689: Finalise addModuleStyles() and addModuleScripts() legacy behaviours.

Krinkle mentioned this in T188689: Finalise addModuleStyles() and addModuleScripts() legacy behaviours.May 22 2019, 8:58 PM
matej_suchanek updated the task description. (Show Details)May 23 2019, 7:02 PM
gerritbot added a comment.May 23 2019, 9:15 PM

Change 512288 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] libs: Remove unused deprecated BufferingStatsdDataFactory::getBuffer()

https://gerrit.wikimedia.org/r/512288

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.7; 2019-05-28); removed MW-1.34-notes (1.34.0-wmf.5; 2019-05-14).May 25 2019, 1:01 AM
gerritbot added a comment.Jun 3 2019, 2:21 PM

Change 514010 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] HTMLForm: Remove deprecated unused getErrors() method

https://gerrit.wikimedia.org/r/514010

gerritbot added a comment.Jun 3 2019, 5:37 PM

Change 514010 merged by jenkins-bot:
[mediawiki/core@master] HTMLForm: Remove deprecated unused getErrors() method

https://gerrit.wikimedia.org/r/514010

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.8; 2019-06-04); removed MW-1.34-notes (1.34.0-wmf.7; 2019-05-28).Jun 3 2019, 6:00 PM
Reedy closed subtask T223005: Replace usages of SpecialPage::getTitle() with SpecialPage::getPageTitle() as Resolved.Jun 7 2019, 10:24 PM
Reedy updated the task description. (Show Details)
gerritbot added a comment.Jun 9 2019, 4:40 AM

Change 515982 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/core@master] Drop SpecialPage::getTitle()

https://gerrit.wikimedia.org/r/515982

gerritbot added a comment.Jun 10 2019, 5:49 AM

Change 515982 merged by jenkins-bot:
[mediawiki/core@master] Drop SpecialPage::getTitle()

https://gerrit.wikimedia.org/r/515982

RazeSoldier updated the task description. (Show Details)Jun 10 2019, 6:28 AM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.10; 2019-06-18); removed MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).Jun 10 2019, 7:00 AM
gerritbot added a comment.Jun 13 2019, 11:52 PM

Change 512288 merged by jenkins-bot:
[mediawiki/core@master] libs: Remove unused deprecated BufferingStatsdDataFactory::getBuffer()

https://gerrit.wikimedia.org/r/512288

gerritbot added a comment.Jun 20 2019, 3:55 PM

Change 514528 had a related patch set uploaded (by Krinkle; owner: Derick Alangi):
[mediawiki/core@master] installer: Remove deprecated method WebInstallerOutput::addWikiText()

https://gerrit.wikimedia.org/r/514528

Krinkle unsubscribed.Jun 20 2019, 4:44 PM
gerritbot added a comment.Jun 20 2019, 9:56 PM

Change 518155 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] GlobalFunctions: Remove deprecated wfCountDown() function from core

https://gerrit.wikimedia.org/r/518155

gerritbot added a comment.Jun 20 2019, 10:53 PM

Change 518155 merged by jenkins-bot:
[mediawiki/core@master] GlobalFunctions: Remove deprecated wfCountDown() function from core

https://gerrit.wikimedia.org/r/518155

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.11; 2019-06-26); removed MW-1.34-notes (1.34.0-wmf.10; 2019-06-18).Jun 20 2019, 11:00 PM
gerritbot added a comment.Jun 21 2019, 9:17 PM

Change 518321 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Skin::outputPage: Drop support for specifying a context, deprecated in 1.20

https://gerrit.wikimedia.org/r/518321

gerritbot added a comment.Jun 21 2019, 10:11 PM

Change 509591 merged by Jforrester:
[mediawiki/core@master] Remove support for calling OutputPage::wrapWikiMsg() with an options parameter

https://gerrit.wikimedia.org/r/509591

gerritbot added a comment.Jun 22 2019, 8:24 PM

Change 518321 merged by jenkins-bot:
[mediawiki/core@master] Skin::outputPage: Drop support for specifying a context, deprecated in 1.20

https://gerrit.wikimedia.org/r/518321

Jdforrester-WMF updated the task description. (Show Details)Jun 24 2019, 11:07 PM
gerritbot added a comment.Jun 30 2019, 6:57 PM

Change 519797 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/core@master] Drop APIEditBeforeSave hook

https://gerrit.wikimedia.org/r/519797

gerritbot added a comment.Jul 1 2019, 7:14 PM

Change 519797 merged by jenkins-bot:
[mediawiki/core@master] Drop APIEditBeforeSave hook

https://gerrit.wikimedia.org/r/519797

RazeSoldier updated the task description. (Show Details)EditedJul 1 2019, 7:19 PM
RazeSoldier subscribed.

I also update the manual for dropping APIEditBeforeSave hook.

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jul 1 2019, 8:00 PM
Jdforrester-WMF updated the task description. (Show Details)Jul 1 2019, 9:00 PM
Jdforrester-WMF updated the task description. (Show Details)Jul 2 2019, 10:15 PM
Jdforrester-WMF mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Sep 13 2019, 5:33 PM
Jdforrester-WMF closed this task as Resolved.Sep 13 2019, 5:36 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF updated the task description. (Show Details)

Well done all, lots of good work. Have made the next one for 1.35.

Jdforrester-WMF updated the task description. (Show Details)Sep 13 2019, 5:37 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 16 2019, 3:01 PM
Krinkle mentioned this in T221431: Actually (hard) deprecate SearchEngine::transformSearchTerm and remove.Dec 20 2019, 5:54 PM
gerritbot added a comment.Feb 23 2020, 1:48 AM

Change 574216 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Docs: Remove reference to UploadVerification hook, removed in 1.34

https://gerrit.wikimedia.org/r/574216

gerritbot added a project: Patch-For-Review.Feb 23 2020, 1:48 AM
DannyS712 subscribed.Feb 23 2020, 1:49 AM
In T220656#5910006, @gerritbot wrote:

Change 574216 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Docs: Remove reference to UploadVerification hook, removed in 1.34

https://gerrit.wikimedia.org/r/574216

Didn't know what bug to tag - hook was removed as part of this task, but is still mentioned

gerritbot added a comment.Feb 24 2020, 12:04 PM

Change 574216 merged by jenkins-bot:
[mediawiki/core@master] Docs: Remove reference to UploadVerification hook, removed in 1.34

https://gerrit.wikimedia.org/r/574216

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 24 2020, 1:00 PM
DannyS712 removed a project: Patch-For-Review.Feb 25 2020, 6:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits