Maniphest T220686

Ensure test mutations only perform reactivity-friendly changes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Pablo-WMDE
	Apr 11 2019, 10:45 AM

Event Timeline

• Pablo-WMDE created this task.Apr 11 2019, 10:45 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2019, 10:45 AM

Jakob_WMDE added a project: Wikidata-Termbox-Iteration-14.Apr 23 2019, 12:17 PM

Jakob_WMDE claimed this task.Apr 29 2019, 9:39 AM

Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-14 board.

Jakob_WMDE updated the task description. (Show Details)Apr 29 2019, 11:16 AM

Jakob_WMDE updated the task description. (Show Details)Apr 29 2019, 2:26 PM

I failed to find a good solution for this. The suggested way to go appears to be to make sure nothing breaks by having good e2e coverage, which is a little unsatisfying. I could imagine coming up with some complicated test helper specifically for mutations but am hesitant to invest a lot of time into that.

Will look into it a short bit and dismiss it if I also fail to make a suggestion.

Looked into the "complicated test helper specifically for mutations" which through a proxy could recursively inspect set and defineProperty calls, would have to be able to re-attach itself to replaced properties, and also be able to tell apart vanilla calls from modification correctly run through Vue.set(). It's not happening.

WMDE-leszek added a project: Wikidata-Termbox-Iteration-15.May 6 2019, 11:35 AM

WMDE-leszek moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-15 board.

• Pablo-WMDE closed this task as Resolved.May 13 2019, 9:51 AM

• Pablo-WMDE moved this task from Doing to Done on the Wikidata-Termbox-Iteration-15 board.

Ensure test mutations only perform reactivity-friendly changesClosed, ResolvedPublicActions

Event Timeline

Ensure test mutations only perform reactivity-friendly changes
Closed, ResolvedPublic
Actions