Page MenuHomePhabricator
Create Task
Maniphest T220730

1.34.0-wmf.5 deployment blockers
Closed, ResolvedPublicRelease
Actions

Description

| Report error |

Tuesday: branch cut pairing with @LarsWirzenius. Should be around noon UTC.

Wednesday: deploy during the American morning window:

19:00–21:00 UTC
12:00–14:00 PDT
21:00–23:00 UTC+2

Thursday: deploy during European window

13:00–15:00 UTC
06:00–08:00 PDT
15:00–17:00 UTC+2

Details

Release Version
1.34.0-wmf.5
Release Date
May 13 2019, 12:00 AM

2019 week 20 1.34-wmf.5 Changes wmf/1.34.0-wmf.5

This MediaWiki Train Deployment is scheduled for the week of Monday, May 13th:

Monday May 13thTuesday, May 14thWednesday, May 15thThursday, May 16thFriday
Backports only.Branch wmf.5 and deploy to Group 0 Wikis.Deploy wmf.5 to Group 1 Wikis.Deploy wmf.5 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.5 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.34.0-wmf.4
Next: 1.34.0-wmf.6
SubjectRepoBranchLines +/-
Group 0 to 1.34.0-wmf.5operations/mediawiki-configmaster+131 -131
Group 0 to 1.34.0-wmf.5operations/mediawiki-configmaster+131 -131
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mmodell created this task.Apr 11 2019, 6:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2019, 6:14 PM
• mmodell assigned this task to hashar.Apr 11 2019, 6:46 PM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptApr 11 2019, 6:46 PM
• mmodell triaged this task as Medium priority.Apr 11 2019, 7:11 PM
hashar added a subscriber: • LarsWirzenius.Apr 27 2019, 9:39 PM

I might pair this one with @LarsWirzenius if there is any interest. And probably check to shift it to an earlier time which better accommodate European timezone :-]

Amorymeltzer subscribed.May 2 2019, 7:36 PM
hashar updated the task description. (Show Details)May 6 2019, 2:33 PM
Jdforrester-WMF subscribed.May 6 2019, 4:24 PM
hashar moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.May 13 2019, 9:01 AM
Stashbot added a comment.May 14 2019, 10:58 AM

Mentioned in SAL (#wikimedia-operations) [2019-05-14T10:58:46Z] <hashar> scap prep 1.34.0-wmf.5 # T220730

gerritbot added a comment.May 14 2019, 11:07 AM

Change 510129 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Group 0 to 1.34.0-wmf.5

https://gerrit.wikimedia.org/r/510129

gerritbot added a project: Patch-For-Review.May 14 2019, 11:07 AM
Stashbot added a comment.May 14 2019, 11:09 AM

Mentioned in SAL (#wikimedia-operations) [2019-05-14T11:09:47Z] <hashar> Deleting 1.33.0-wmf.23 from deploy1001 # T220730

Stashbot added a comment.May 14 2019, 11:30 AM

Mentioned in SAL (#wikimedia-operations) [2019-05-14T11:29:59Z] <hashar> Deleting 1.33.0-wmf.24 from deploy1001 # T220730

gerritbot added a comment.May 14 2019, 1:09 PM

Change 510129 merged by jenkins-bot:
[operations/mediawiki-config@master] Group 0 to 1.34.0-wmf.5

https://gerrit.wikimedia.org/r/510129

gerritbot added a comment.May 14 2019, 1:18 PM

Change 510158 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Group 0 to 1.34.0-wmf.5

https://gerrit.wikimedia.org/r/510158

hashar added a subtask: T223276: keyholder has just disarmed everywhere (train blocker).May 14 2019, 1:37 PM
fgiunchedi closed subtask T223276: keyholder has just disarmed everywhere (train blocker) as Resolved.May 14 2019, 2:03 PM
gerritbot added a comment.May 14 2019, 2:49 PM

Change 510158 merged by jenkins-bot:
[operations/mediawiki-config@master] Group 0 to 1.34.0-wmf.5

https://gerrit.wikimedia.org/r/510158

Jdforrester-WMF closed subtask T223281: [{exception_id}] {exception_url} ErrorException from line 599 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditor.php: PHP Notice: Undefined variable: restbaseHeaders as Resolved.May 14 2019, 3:59 PM
hashar updated the task description. (Show Details)May 14 2019, 6:36 PM
• Yyn1312 subscribed.May 15 2019, 3:53 AM
Stashbot added a comment.May 15 2019, 7:42 PM

Mentioned in SAL (#wikimedia-operations) [2019-05-15T19:41:58Z] <hashar> group 1 promoted to 1.34.0-wmf.5 apparently without any issue # T220730

hashar added a subtask: T223445: commonswiki: id3handler ErrorException from line 16 of WebMHandler.php: PHP Notice: Undefined index: comments.May 16 2019, 1:28 PM
Aklapper added a subtask: T223449: Cannot search for anything: BadMethodCallException in search on some wikis.May 16 2019, 2:02 PM
Aklapper added a comment.EditedMay 16 2019, 2:06 PM

T223446 might be another blocker candidate, not sure how widespread the problem is so I didn't mark it as blocker

Jdforrester-WMF added a subtask: T223440: Special:Contributions on meta.wikimedia.org: associated=1: "PHP fatal error: Call to undefined method MediaWiki\MediaWikiServices::getAssociated()".May 16 2019, 3:24 PM
Jdforrester-WMF closed subtask T223449: Cannot search for anything: BadMethodCallException in search on some wikis as Resolved.May 16 2019, 3:52 PM
hashar closed subtask T223448: ErrorException from line 1274 of /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php: PHP Warning: fread() expects parameter 1 to be resource, boolean given as Resolved.May 17 2019, 3:24 PM
hashar closed this task as Resolved.May 17 2019, 3:27 PM
hashar removed a subtask: T223445: commonswiki: id3handler ErrorException from line 16 of WebMHandler.php: PHP Notice: Undefined index: comments.
hashar added subscribers: dcausse, matthiasmullie.

It went mostly fine, although there are some issues I have not caught in due time:

And thanks @Jdforrester-WMF for the various triages/feedback etc.

hashar reopened subtask T223447: AbuseFilter log error on fiwiki: /srv/mediawiki/php-1.34.0-wmf.5/includes/Revision.php:639 Call to a member function getId() on a non-object (null) as Open.May 20 2019, 9:49 AM
hashar removed a subtask: T223447: AbuseFilter log error on fiwiki: /srv/mediawiki/php-1.34.0-wmf.5/includes/Revision.php:639 Call to a member function getId() on a non-object (null).May 20 2019, 9:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL