Page MenuHomePhabricator

Separate out events in EditorOverlay/EditorOverlayBase/VisualEditorOverlay
Open, LowPublic

Description

The EditorOverlayBase class defines many events on the prototype and is one of the main reasons for its existence.

It would be helpful to instead define these events as anonymous functions bound to the overlay class.

Suggested action

  • the EditorOverlay and VisualEditorOverlay define events objects that point to functions defined inside a new file editorEvents
  • EditorOverlayBase no longer defines any events so events are inherited directly from the Overlay class.