Maniphest T220772

Don’t use heading elements (<h4>) in Wikibase diffs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	LucasWerkmeister
	Apr 11 2019, 10:09 PM

Description

As a tool developer, I want to embed diffs generated by Wikibase in my tool, in order to present an edit to my users.

Problem:
Wikibase wraps time values in diffs in <h4> elements. On Wikibase pages, this looks fine, due to the stylesheets in effect (I’m not sure if the relevant stylesheets are by Wikibase or general to MediaWiki):

Screenshot_2019-04-11 Difference between revisions of Lara Méndez López (Q20535136) - Wikidata.png (352×845 px, 32 KB)

However, when embedded in an external tool a using different set of stylesheets, the heading becomes disturbingly large:

I’m not sure why we use <h4> elements for this. (They seem to have been introduced in PS4 of I29c083b31c.) Semantically, I’m pretty sure the date values are not headings. This also causes at least one other issue, see T87021.

As far as I can tell from the code, quantity and globe coordinate diffs also use <h4> elements, though I don’t recall those being problematic in SpeedPatrolling – I suppose they’re just less frequent.

Example:

random example edit on Wikidata: https://www.wikidata.org/w/index.php?diff=910428737
the same edit in SpeedPatrolling: https://tools.wmflabs.org/speedpatrolling/diff/910428737/

Acceptance criteria:

time, quantity and globe coordinate diffs no longer use heading elements

Details

	Subject	Repo	Branch	Lines +/-
	Don’t style heading elements in Wikibase diffs	mediawiki/extensions/Wikibase	master	+0 -4
	Don’t use heading elements in Wikibase diffs	mediawiki/extensions/Wikibase	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T229069: Don’t use heading elements (<h4>) in Wikibase diffs for coordinates and quantities
T87021: Wikibase diffs for datetime display the property label on a separate line
Mentioned Here: T229069: Don’t use heading elements (<h4>) in Wikibase diffs for coordinates and quantities
T87021: Wikibase diffs for datetime display the property label on a separate line

Event Timeline

LucasWerkmeister created this task.Apr 11 2019, 10:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2019, 10:09 PM

@daniel can you chime in/give some background information?

Lydia_Pintscher added a project: Wikidata-Campsite.Apr 14 2019, 4:23 PM

In T220772#5109801, @Lydia_Pintscher wrote:

@daniel can you chime in/give some background information?

I don't think there is a specific reason for this. It's a "heading" in the sense that it's followed by more detailed, and it "looked right" at the time. But the choice of <h4> is dubious. Replacing it should not be a problem.

Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Apr 17 2019, 6:39 AM

Michael claimed this task.Apr 17 2019, 10:35 AM

Michael edited projects, added User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Michael moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 17 2019, 10:39 AM

Change 504527 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Don’t use heading elements in Wikibase diffs

https://gerrit.wikimedia.org/r/504527

gerritbot added a project: Patch-For-Review.Apr 17 2019, 10:55 AM

Michael moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 17 2019, 10:56 AM

hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 17 2019, 11:38 AM

Michael moved this task from 🗃️ Incoming to 💬 waiting on other's work or feedback on the User-Michael board.Apr 17 2019, 2:37 PM

Michael moved this task from 💬 waiting on other's work or feedback to ✅ my work done on the User-Michael board.

Change 504527 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don’t use heading elements in Wikibase diffs

https://gerrit.wikimedia.org/r/504527

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 17 2019, 7:00 PM

@Lucas_Werkmeister_WMDE Can you verify and close this one?

I can verify it once it’s been deployed on Wikidata. Unfortunately, there’s no train this week (releng offsite), so that’ll have to wait until next Wednesday or Thursday.

Yep, much better now :)

LucasWerkmeister closed this task as Resolved.May 2 2019, 9:19 AM

LucasWerkmeister moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Lucas_Werkmeister_WMDE mentioned this in T87021: Wikibase diffs for datetime display the property label on a separate line.May 2 2019, 9:25 AM

I just noticed that coordinate values still use h4 (example link). Quantity values, too, according to a code search (didn’t see that “in the wild” yet). Should I open another task for those or do we reopen this one?

Thanks for finding this 👍 But let's make that a new which that references this one. Otherwise, it might be confusing

Alright, done: T229069: Don’t use heading elements (<h4>) in Wikibase diffs for coordinates and quantities

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2019, 11:10 PM

Change 703920 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/extensions/Wikibase@master] Don’t style heading elements in Wikibase diffs

https://gerrit.wikimedia.org/r/703920

gerritbot added a project: Patch-For-Review.Jul 11 2021, 10:56 AM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 11 2021, 11:15 AM

Change 703920 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Don\u2019t style heading elements in Wikibase diffs