Page MenuHomePhabricator

Consider creating a puppet-compiler equivalent for mediawiki-config.git
Open, LowPublic

Description

wikimedia-operations
<James_F> Reedy: BTW – scary, or insanely scary: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/501003 :-)
<Krenair> I wonder if we could do with a puppet-compiler type thing but for mediawiki-config James_F 
<James_F> Krenair: Hmm. How would that work?
<Reedy> dump $GLOBALS before and after for a specific wiki?
<Krenair> well I guess you'd put a change number in and a list of database names
<Krenair> check GLOBALS
<Krenair> run some diffs
<Krenair> that sort of thing
<Krenair> yeah like Reedy said
<James_F> Right.
<James_F> Could be interesting.
<Reedy> It'd help with some of the "will this result in the changes I expect"
<James_F> We'd have to mask out the bits of $GLOBALS we don't want public, though.
<Krenair> well it wouldn't run with the live prod secrets James_F 
<Krenair> puppet-compiler uses labs/private.git
<James_F> Right.
<Krenair> and in mediawiki-config we have private/PrivateSettings.php.example
<Krenair> which is not actually complete IIRC
<Krenair> but that would be simple enough for someone to fix if they wanted
<James_F> > echo count($GLOBALS);
<James_F> 2325
<James_F> So… we'd have 1000 wikis x 2300 globals. The diff will be pretty.
<Krenair> wouldn't always have to run it against all wikis
<James_F> If we wanted to spot that you're not breaking random other wikis, you really would, surely?
<Krenair> puppet-compiler will let you do all hosts but it will also let you do one or a list or whatever
<Krenair> well you could do all wikis
<Krenair> but at that point dealing with the diff that comes out is your problem :p
<James_F> `foreach wiki in all.dblist do  … `
<James_F> Krenair: File a quick Phab task so we don't forget?
<Krenair> yeah
<Reedy> mediawiki-compiler

Event Timeline

Krenair created this task.Apr 11 2019, 11:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2019, 11:05 PM
Joe edited projects, added serviceops-radar; removed serviceops.Jun 21 2019, 10:06 AM
Joe added a subscriber: Joe.
greg triaged this task as Low priority.Jul 26 2019, 12:42 AM
greg moved this task from INBOX to Later / Need volunteer on the Release-Engineering-Team-TODO board.

I think this and T208493 are essentially dupes of each other.

I consider this to be part of that?

I consider this to be part of that?

Yup, that's true.

mmodell added a subscriber: mmodell.