Page MenuHomePhabricator
Create Task
Maniphest T220780

Move config for disabling web login-success notifications to LoginNotify extension
Closed, ResolvedPublic
Actions

Description

From T220762: [betalabs] Stuck cross-wiki notification

In T220762#5105630, @Catrope wrote:

BTW @Niharika is it intentional that login-success notifications are not deliverable through the web (only by email), and users cannot choose for them to be web-delivered even if they want to? If it is intentional, I'd recommend this config be moved from CommonSettings.php into the extension.

Details

SubjectRepoBranchLines +/-
LoginNotify: remove setting that was moved to the extension itselfoperations/mediawiki-configmaster+0 -1
Disable web notifications for login-successmediawiki/extensions/LoginNotifymaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

• Niharika triaged this task as Medium priority.Apr 11 2019, 11:49 PM
• Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2019, 11:49 PM
• Niharika mentioned this in T220762: [betalabs] Stuck cross-wiki notification .Apr 11 2019, 11:52 PM
gerritbot added a comment.Apr 12 2019, 7:56 PM

Change 503465 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/LoginNotify@master] Disable web notifications for login-success

https://gerrit.wikimedia.org/r/503465

gerritbot added a project: Patch-For-Review.Apr 12 2019, 7:56 PM
Catrope mentioned this in rELGNfd827a88a078: Disable web notifications for login-success.Apr 12 2019, 7:57 PM
gerritbot added a comment.Apr 13 2019, 2:07 AM

Change 503465 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Disable web notifications for login-success

https://gerrit.wikimedia.org/r/503465

gerritbot added a comment.Apr 13 2019, 2:13 AM

Change 503546 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[operations/mediawiki-config@master] LoginNotify: remove setting that was moved to the extension itself

https://gerrit.wikimedia.org/r/503546

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Apr 13 2019, 3:00 AM
• Niharika added a project: Community-Tech-Sprint.Apr 25 2019, 6:02 PM
• Niharika moved this task from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
• Niharika moved this task from Needs Discussion to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Apr 30 2019, 10:47 PM
gerritbot added a comment.May 6 2019, 11:21 PM

Change 503546 merged by jenkins-bot:
[operations/mediawiki-config@master] LoginNotify: remove setting that was moved to the extension itself

https://gerrit.wikimedia.org/r/503546

• jmatazzoni subscribed.May 9 2019, 5:19 PM

@Niharika can I assign this to you? Or can you just claim it?

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:30 PM
MBinder_WMF moved this task from In Sprint 🏃‍♀️🏃‍♂️ to Resolved 2018-19 Q4 on the Community-Tech board.May 28 2019, 3:58 PM
MBinder_WMF edited projects, added Community-Tech (Resolved 2018-19 Q4); removed Community-Tech.
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Resolved 2018-19 Q4). · View Herald TranscriptMay 28 2019, 3:58 PM
MBinder_WMF edited projects, added Community-Tech (Resolved 2018-19 Q4); removed Community-Tech.May 28 2019, 4:03 PM
MBinder_WMF moved this task from Ready to Needs Review/Feedback on the Community-Tech (Resolved 2018-19 Q4) board.May 28 2019, 4:05 PM
MaxSem subscribed.May 29 2019, 5:09 PM

We're done here, right?

Catrope closed this task as Resolved.May 29 2019, 5:11 PM
Catrope claimed this task.

Yes

• Niharika moved this task from Needs Review/Feedback to Done on the Community-Tech (Resolved 2018-19 Q4) board.May 29 2019, 5:12 PM
Reedy moved this task from Backlog to Done on the MediaWiki-extensions-LoginNotify board.Apr 4 2020, 2:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL