Page MenuHomePhabricator

Move config for disabling web login-success notifications to LoginNotify extension
Closed, ResolvedPublic

Description

From T220762: [betalabs] Stuck cross-wiki notification

BTW @Niharika is it intentional that login-success notifications are not deliverable through the web (only by email), and users cannot choose for them to be web-delivered even if they want to? If it is intentional, I'd recommend this config be moved from CommonSettings.php into the extension.

Details

Related Gerrit Patches:
operations/mediawiki-config : masterLoginNotify: remove setting that was moved to the extension itself
mediawiki/extensions/LoginNotify : masterDisable web notifications for login-success

Event Timeline

Niharika triaged this task as Normal priority.Apr 11 2019, 11:49 PM
Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2019, 11:49 PM

Change 503465 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/LoginNotify@master] Disable web notifications for login-success

https://gerrit.wikimedia.org/r/503465

Change 503465 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Disable web notifications for login-success

https://gerrit.wikimedia.org/r/503465

Change 503546 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[operations/mediawiki-config@master] LoginNotify: remove setting that was moved to the extension itself

https://gerrit.wikimedia.org/r/503546

Change 503546 merged by jenkins-bot:
[operations/mediawiki-config@master] LoginNotify: remove setting that was moved to the extension itself

https://gerrit.wikimedia.org/r/503546

@Niharika can I assign this to you? Or can you just claim it?

MaxSem added a subscriber: MaxSem.May 29 2019, 5:09 PM

We're done here, right?

Catrope closed this task as Resolved.May 29 2019, 5:11 PM
Catrope claimed this task.

Yes