Page MenuHomePhabricator

move/update gerrit-admin@wikimedia.org mail alias
Closed, ResolvedPublic

Description

While removing jenkins-bot@ for T220664 i noticed we also still have gerritadmin@wikimedia.org and recipients are just @demon and @hashar

Given recent changes about Gerrit admin roles and that Chad isn't with WMF anymore we should update that.

Separately we would like to move aliases to Google groups handled by OIT in many, but not all, cases (T122144).

73 gerrit: :blackhole:
74 
75 # Gerrit admins
76 gerritadmin:    chorohoe, amusso

Event Timeline

Dzahn created this task.Apr 12 2019, 6:00 PM
Dzahn updated the task description. (Show Details)
Dzahn updated the task description. (Show Details)

oh yea, and fwiw: gerrit@ -> blackhole

Dzahn removed Dzahn as the assignee of this task.Apr 12 2019, 6:02 PM

gerritadmin was apparently to authenticate with Bugzilla. The only trace I found for that email is c103a02dff2f84fa42a9ff378e14a7c416cc654f from November 2014. Lets delete it.


gerrit is used by Gerrit when its doing various operations on the git repositories, typically a configuration change. Its defined in:

modules/gerrit/templates/gerrit.config.erb
[user]
    email = gerrit@wikimedia.org

From Gerrit doc https://gerrit.wikimedia.org/r/Documentation/config-gerrit.html#user.name :

Email address that Gerrit refers to itself as when it creates a new Git commit, such as a merge commit during change submission.
If not set, Gerrit generates this as "gerrit@hostname`", where `hostname is the hostname of the system Gerrit is running on.
By default, not set, generating the value at startup.

So its really for robot usage and we do not need it to be a recipient of any email. We should keep the blackhole.

Dzahn closed this task as Resolved.Apr 12 2019, 11:01 PM
Dzahn claimed this task.

gerritadmin was apparently to authenticate with Bugzilla. Lets delete it.

Done! Deleted.

We should keep the blackhole.

Kept, along with a comment leading to your explanation above.

Thanks!