SearchOverlay is 440 lines long. A good chunk of that is View logic that could be split into a separate file, SearchResultsView or something like that. SearchResultsView would then be composed into SearchOverlay.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T221022 [EPIC] Divide MobileFrontend component concerns | |||
| Declined | None | T220849 Separate View code from SearchOverlay |
I think we'll need to refactor the Overlay code right? The search input is part of the header, so we'd need to make it possible to compose a SearchInputItem into that header that drives the results in the content of the overlay.
Change 527608 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Super-light refactor of SearchOverlay
I took a look at this today, and made a slight improvement (although incomplete) refactor in this direction.
^
Change 527608 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Super-light refactor of SearchOverlay
Change 529833 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Dev: Pull out SearchHeader from SearchOverlay
Change 529833 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Dev: Pull out SearchHeader from SearchOverlay
This is probably not worth working on any further because of T281930 so I'm declining.