Page MenuHomePhabricator

Separate View code from SearchOverlay
Open, MediumPublic

Description

SearchOverlay is 440 lines long. A good chunk of that is View logic that could be split into a separate file, SearchResultsView or something like that. SearchResultsView would then be composed into SearchOverlay.

Acceptance criteria

  • Some of the View code has been moved from SearchOverlay into a new file and is independent of SearchOverlay
  • SearchOverlay uses the new file

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterDev: Pull out SearchHeader from SearchOverlay
mediawiki/extensions/MobileFrontend : masterSuper-light refactor of SearchOverlay

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2019, 6:57 PM

I think we'll need to refactor the Overlay code right? The search input is part of the header, so we'd need to make it possible to compose a SearchInputItem into that header that drives the results in the content of the overlay.

Maybe this isn't a good candidate to work on right now then.

Change 527608 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Super-light refactor of SearchOverlay

https://gerrit.wikimedia.org/r/527608

Jdlrobson triaged this task as Medium priority.Aug 2 2019, 6:01 PM

I took a look at this today, and made a slight improvement (although incomplete) refactor in this direction.
^

Change 527608 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Super-light refactor of SearchOverlay

https://gerrit.wikimedia.org/r/527608

Change 529833 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Dev: Pull out SearchHeader from SearchOverlay

https://gerrit.wikimedia.org/r/529833

Change 529833 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Dev: Pull out SearchHeader from SearchOverlay

https://gerrit.wikimedia.org/r/529833