Page MenuHomePhabricator

Separate Toggler storage responsibilities
Closed, DuplicatePublic2 Estimated Story Points

Description

Toggler does way too much and is impossible to reason about. Start by moving the mw.storage interactions to a new file, either a section storage specific file or a utility.

Acceptance criteria

  • All mw.storage related interactions occur in a distinct file
  • Toggler is updated to use the new file

Related Objects

Event Timeline

We pointed this as a small because this task is just about isolating the storage and parse interactions. Toggler should only care about the un/marshaller not where it's stored. It's using JSON.parse / stringify which isn't great and could be better typed. Storage is already abstracted as mw.storage.

Jdlrobson triaged this task as Medium priority.Apr 24 2019, 1:38 AM
Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.