Page MenuHomePhabricator
Create Task
Maniphest T220854

"Preview mode" parser output gets re-used for page views (affects addWarning and REVISIONID processing)
Closed, ResolvedPublic
Actions

Description

mw.addWarning() was added after bug T137900 was fixed. It was intended to be used instead of revisionid, where messages should only be shown in preview mode. This preview functionality is mentioned in the documentation, with the change https://mediawiki.org/wiki/Special:Diff/2386645, and also in comment T137900#2384230.

As can be seen on https://en.wikipedia.org/wiki/German_Air_Force, after Module:Check for unknown parameters was changed to use mw.addWarning, the function does show the warning even when the page is not previewed. mw.addWarning does not work when the warning message which is passed through it contains a div.

Details

SubjectRepoBranchLines +/-
Add vary-revision-exist flag to handle {{REVISIONID}} and parser cachemediawiki/coremaster+15 -1
Add vary-revision-exist flag to handle {{REVISIONID}} and parser cachemediawiki/corewmf/1.33.0-wmf.25+15 -1
Customize query in gerrit

Related Objects

Event Timeline

Snaevar created this task.Apr 12 2019, 9:12 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptApr 12 2019, 9:12 PM
JJMC89 updated the task description. (Show Details)Apr 12 2019, 9:21 PM
JJMC89 added a subscriber: Legoktm.
JJMC89 added a subscriber: Krinkle.Apr 12 2019, 10:24 PM
Krinkle renamed this task from mw.addWarning shows in read mode with an div passed through it. to "Preview mode" parser output gets re-used for page views (affects addWarning and REVISIONID processing).Apr 12 2019, 11:43 PM
Krinkle mentioned this in T137900: Deal with poor edit stash hit rate due to Lua modules using {{REVISIONID}}.

I believe this is not due to an issue with addWarning(). Rather, it has to do with how the parser output is stored and re-used after the fact.

The problem is also seen through templates that use {{REVISIONID}} to detect preview mode.

In both cases, it can be fixed by purging the page (until the next edit).

Krinkle triaged this task as High priority.Apr 12 2019, 11:45 PM
Krinkle edited projects, added Performance-Team; removed Scribunto.
gerritbot added a comment.Apr 12 2019, 11:55 PM

Change 503537 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache

https://gerrit.wikimedia.org/r/503537

gerritbot added a project: Patch-For-Review.Apr 12 2019, 11:55 PM
gerritbot added a comment.Apr 13 2019, 12:23 AM

Change 503540 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@wmf/1.33.0-wmf.25] Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache

https://gerrit.wikimedia.org/r/503540

Krinkle closed this task as Resolved.Apr 13 2019, 12:27 AM
Krinkle assigned this task to aaron.
Krinkle raised the priority of this task from High to Unbreak Now!.
Krinkle removed a project: Patch-For-Review.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 13 2019, 12:27 AM
Stashbot added a comment.Apr 13 2019, 12:32 AM

Mentioned in SAL (#wikimedia-operations) [2019-04-13T00:32:44Z] <krinkle@deploy1001> Synchronized php-1.33.0-wmf.25/includes/: Idc19cc29764a / T220854 - hot fix (duration: 05m 37s)

gerritbot added a comment.Apr 13 2019, 12:34 AM

Change 503540 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.25] Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache

https://gerrit.wikimedia.org/r/503540

gerritbot added a comment.Apr 13 2019, 12:43 AM

Change 503537 merged by jenkins-bot:
[mediawiki/core@master] Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache

https://gerrit.wikimedia.org/r/503537

ReleaseTaggerBot added projects: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Apr 13 2019, 1:00 AM
CDanis mentioned this in T221035: scap no longer !log'ging to server admin log.Apr 15 2019, 7:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL