Maniphest T220862

Remove hideOnExitClick from ImageCarousel prototype
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

ImageCarousel.js has a hideOnExitClick on its prototype:

/**
 * @memberof ImageCarousel
 * @instance
 */
hideOnExitClick: false,

This was a leftover artifact from the ImageOverlay composition refactor (T216198). Since ImageCarousel does not extend Overlay, this property can safely be removed as nothing is using it.

Acceptance criteria

Obliterate the property!

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove hideOnExitClick from ImageCarousel prototype	mediawiki/extensions/MobileFrontend	master	+2 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T221022 [EPIC] Divide MobileFrontend component concerns
		Resolved		pmiazga	T220862 Remove hideOnExitClick from ImageCarousel prototype

Event Timeline

• nray created this task.Apr 12 2019, 11:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2019, 11:10 PM

Change 503522 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Remove hideOnExitClick from ImageCarousel prototype

https://gerrit.wikimedia.org/r/503522

gerritbot added a project: Patch-For-Review.Apr 12 2019, 11:10 PM

• Niedzielski added a parent task: T221022: [EPIC] Divide MobileFrontend component concerns.Apr 15 2019, 5:45 PM

Change 503522 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove hideOnExitClick from ImageCarousel prototype

https://gerrit.wikimedia.org/r/503522