Maniphest T220865

Remove `Overlay.EVENT_EXIT` from Overlay.js
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

Overlay.js attaches an EVENT_EXIT to its constructor:

/*
 * Fires when close button is clicked. Not to be confused with hide event.
 * @memberof Overlay
 * @event Overlay#Overlay-exit
 */
Overlay.EVENT_EXIT = 'Overlay-exit';

However, nothing listens to this event. Let's make Overlay.js stop firing this event and remove all references to it from Overlay.js!

Acceptance criteria

All references to EVENT_EXIT are removed from Overlay.js

Details

	Subject	Repo	Branch	Lines +/-
	Remove `Overlay.EVENT_EXIT` from Overlay.js	mediawiki/extensions/MobileFrontend	master	+2 -11

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T221022 [EPIC] Divide MobileFrontend component concerns
		Resolved		pmiazga	T220865 Remove `Overlay.EVENT_EXIT` from Overlay.js

Event Timeline

• nray created this task.Apr 12 2019, 11:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2019, 11:34 PM

Change 503535 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Remove Overlay.EVENT_EXIT from Overlay.js

https://gerrit.wikimedia.org/r/503535

gerritbot added a project: Patch-For-Review.Apr 12 2019, 11:36 PM

• Niedzielski added a parent task: T221022: [EPIC] Divide MobileFrontend component concerns.Apr 15 2019, 5:45 PM

Change 503535 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove Overlay.EVENT_EXIT from Overlay.js

https://gerrit.wikimedia.org/r/503535

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 16 2019, 8:00 PM