Overlay.js contains an instance variable hasLoadError:
function Overlay( props ) {
this.isIos = browser.isIos();
// Set to true when overlay has failed to load
this.hasLoadError = false;
...
}This used to be changed by ImageOverlay (before T216198) whenever an image failed to load so that OverlayManager wouldn't cache the overlay. However, this is no longer the case and nothing actually sets this instance variable to true now. Therefore, all logic involving it can be removed from Overlay and OverlayManager.js!
Acceptance criteria
- The hasLoadError instance variable is removed from Overlay.js
- All logic related to hasLoadError is removed from OverlayManager.